Project

General

Profile

Actions

Task #37951

closed

Remove "http://" prefix from domain record domains or prevent saving the form

Added by Philipp Gampe almost 12 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2012-06-12
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Sprint Focus:
On Location Sprint

Description

If a user puts http://example.org in the domain record field for the domain, the scheme is not removed, but included in the URL like so: http://http://example.org.

This is very confusing and a lot of new users make this mistake even though the label explicitly says to not include the scheme here.

Make sure that TYPO3 recognizes this and either silently removes the scheme in such case or that TYPO3 produces a warning (user eval function?) and refuses saving the entry.


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #72331: Linkwizard treats external links with an extension not as external urlClosed2015-12-18

Actions
Related to TYPO3 Core - Epic #83652: EXT: Redirects module - Umbrella issueClosed2018-01-22

Actions
Actions #1

Updated by Philipp Gampe almost 12 years ago

Bugfix or feature?

Actions #2

Updated by Thomas Deinhamer almost 12 years ago

New 'eval' functions?
E.g. 'domain' and 'url'.

Actions #3

Updated by Philipp Gampe almost 12 years ago

Would be fine with me, but than it is a feature.

Actions #4

Updated by Mathias Schreiber over 9 years ago

  • Tracker changed from Bug to Feature
  • Category set to FormEngine aka TCEforms
  • Target version set to 7.0
Actions #5

Updated by Mathias Schreiber over 9 years ago

  • Status changed from New to Accepted
Actions #6

Updated by Mathias Schreiber over 9 years ago

  • Target version changed from 7.0 to 7.1 (Cleanup)
Actions #7

Updated by Benni Mack almost 9 years ago

  • Target version changed from 7.1 (Cleanup) to 7.4 (Backend)
Actions #8

Updated by Susanne Moog almost 9 years ago

  • Target version changed from 7.4 (Backend) to 7.5
Actions #9

Updated by Benni Mack over 8 years ago

  • Target version changed from 7.5 to 8 LTS
Actions #10

Updated by Riccardo De Contardi about 7 years ago

  • Target version changed from 8 LTS to 9.0
Actions #11

Updated by Susanne Moog over 6 years ago

  • Related to Epic #83652: EXT: Redirects module - Umbrella issue added
Actions #12

Updated by Susanne Moog over 6 years ago

  • Target version changed from 9.0 to 9.2

With the new redirects module we already implemented a basic host validation which could be reused in this case.

Actions #13

Updated by Gerrit Code Review about 6 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56318

Actions #14

Updated by Łukasz Uznański about 6 years ago

  • Sprint Focus set to On Location Sprint
Actions #15

Updated by Gerrit Code Review about 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56318

Actions #16

Updated by Gerrit Code Review about 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56318

Actions #17

Updated by Gerrit Code Review about 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56318

Actions #18

Updated by Gerrit Code Review about 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56318

Actions #19

Updated by Gerrit Code Review about 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56318

Actions #20

Updated by Benni Mack about 6 years ago

  • Tracker changed from Feature to Task
  • TYPO3 Version set to 9
Actions #21

Updated by Susanne Moog about 6 years ago

  • Target version changed from 9.2 to 9.3
Actions #22

Updated by Susanne Moog almost 6 years ago

  • Target version changed from 9.3 to 9.4
Actions #23

Updated by Gerrit Code Review almost 6 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56318

Actions #24

Updated by Łukasz Uznański almost 6 years ago

  • Sprint Focus deleted (On Location Sprint)
Actions #25

Updated by Benni Mack over 5 years ago

  • Status changed from Under Review to Needs Feedback

Hey Philipp, I think this can be closed now, right?

Actions #26

Updated by Riccardo De Contardi over 5 years ago

I tried the following test with 8.7.19:

1) home page > list view > create a new record, type: domain
2) put in the Domain field: http://typo3.test.it/
3) Save

Results

1) no warning when saving the domain, the field is saved.
2) on frontend, the pages are predended with:

http//typo3.test.it/index.php?id=34

the colon is missing

3) if I write in the field: typo3.test.it/ everything works fine.

Actions #27

Updated by Susanne Moog over 5 years ago

  • Target version changed from 9.4 to 8.7.19
  • TYPO3 Version changed from 9 to 8
Actions #28

Updated by Susanne Moog over 5 years ago

  • Target version deleted (8.7.19)
Actions #29

Updated by Susanne Moog over 5 years ago

  • Sprint Focus set to On Location Sprint
Actions #30

Updated by Benni Mack over 5 years ago

  • Status changed from Needs Feedback to Closed

we finally resolved this by using a full URL (not just the domain name + path) in the new site handling, as sys_domain will be removed, I consider closing this. @Philipp - If you still think this should be fixed, please-reopen the ticket.

Thanks for your report again!

Actions

Also available in: Atom PDF