Bug #38645

New error_reporting settings cause notice "undefined constant E_DEPRECATED " with PHP 5.2

Added by Ivan Dharma Kartolo 11 months ago. Updated 11 months ago.

Status:Resolved Start date:2012-07-04
Priority:Must have Due date:
Assignee:- % Done:

100%
Category:Performance
Target version:4.5.18
TYPO3 Version:4.5 Complexity:
PHP Version:5.2
Votes: 0

Description

After #35154 updating to 4.5.17 shows the following PHP Notice:

PHP Notice:  Use of undefined constant E_DEPRECATED - assumed 'E_DEPRECATED' in typo3_src-4.5.17/typo3/init.php on line 69

Problem is, that the site still uses PHP 5.2.

Since TYPO3 4.5.x should be still working with PHP 5.2, I thinks the line

error_reporting(E_ALL & ~(E_STRICT | E_NOTICE | E_DEPRECATED));

should be change to

error_reporting(E_ALL & ~(E_STRICT | E_NOTICE));

in typo3/init.php

Thanks,

Ivan

Related issues

related to Core - Bug #39232: PHP error_reporting cannot be set properly, E_STRICT erro... Resolved 2012-07-25
related to Core - Bug #38691: Exclude E_STRICT on PHP 5.4 Closed 2012-07-05
follows Core - Bug #35154: Exclude E_STRICT from exceptionalErrors in PHP 5.4 Closed 2012-03-22

Associated revisions

Revision eb317e77
Added by Ivan Dharma Kartolo 11 months ago

[BUGFIX] E_DEPRECATED does not exist in PHP 5.2

Because TYPO3 4.5.x should also work on PHP 5.2, the E_DEPRECATED constant
must be removed, since it produces notices.

Change-Id: Idb0e7ffb327a44088b966e04008d8efb03555b3b
Fixes: #38645
Releases: 4.5
Reviewed-on: http://review.typo3.org/12612
Reviewed-by: Philipp Gampe
Reviewed-by: Markus Klein
Reviewed-by: Ivan Dharma Kartolo
Tested-by: Ivan Dharma Kartolo
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

History

#1
Updated by Ivan Dharma Kartolo 11 months ago

E_DEPRECATED exists since PHP 5.3.0. See http://php.net/manual/en/errorfunc.constants.php

#2
Updated by Gerrit Code Review 11 months ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/12611

#3
Updated by Sven Juergens 11 months ago

same Problem here.

There was also this change

- if (defined('E_DEPRECATED')) {
- error_reporting(E_ALL ^ E_NOTICE ^ E_DEPRECATED);
- } else {
- error_reporting(E_ALL ^ E_NOTICE);
- }

+ error_reporting(E_ALL & ~(E_STRICT | E_NOTICE | E_DEPRECATED));

in

typo3_src-4.5.17/typo3/thumbs.php
typo3_src-4.5.17/index.php
typo3_src-4.5.17/typo3/install/index.php

#4
Updated by Chris topher 11 months ago

  • Subject changed from E_DEPRECATED in 4.5.17 to New error_reporting settings cause notice "undefined constant E_DEPRECATED " with PHP 5.2

#5
Updated by Gerrit Code Review 11 months ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/12612

#6
Updated by Gerrit Code Review 11 months ago

Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/12612

#7
Updated by Gerrit Code Review 11 months ago

Patch set 3 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/12612

#8
Updated by Gerrit Code Review 11 months ago

Patch set 4 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/12612

#9
Updated by Oliver Hader 11 months ago

Argh...

#10
Updated by Oliver Hader 11 months ago

Ivan, what Linux distribution do you use - I'd like to find out how spread that issue is...

#11
Updated by Ivan Dharma Kartolo 11 months ago

  1. CentOS 5.2
  2. Ubuntu 9.04

I know they are kinda old and not supported anymore (by distro) but some shared hoster still use it, rofl :)

#12
Updated by Ivan Dharma Kartolo 11 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF