Project

General

Profile

Actions

Bug #38698

closed

css_styled_content overwrites contentRenderingTemplates array

Added by Thomas Deinhamer almost 12 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Content Rendering
Target version:
-
Start date:
2012-07-06
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.7
PHP Version:
5.3
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

The extension css_styled_content makes it hard to define
custom content rendering templates in the TYPO3_CONF_VARS
array, because it just overwrites the existing value.

If you install/use an extension which is installed before
css_styled_content and sets it's own content rendering
templates, css_styled_content overwrites the array.

Imho to allow custom content rendering templates the
extension CSC should check if the array exists before,
and create it, if not available.

A first patch is attached for TYPO3 4.7, but I'd like
to have this also in 4.5 LTS and 4.6, because I think
it's more a bug and not a feature.

Is there a chance to get this into the next minor release?

Thanks a lot!


Files

content_rendering_templates.patch (1.28 KB) content_rendering_templates.patch Thomas Deinhamer, 2012-07-06 01:18
Actions #1

Updated by Mario Rimann almost 12 years ago

Do you have an example Extension that can be used to test this change?

Actions #2

Updated by Thomas Deinhamer almost 12 years ago

Yes, you can checkout hype_html5 from the current trunk:
http://forge.typo3.org/projects/show/extension-hype_html5

First install it and then to test the behaviour you need
to edit localconf.php and put hype_html5 in front of
css_styled_content regarding extList order.

...['extList'] = '...,...,hype_html5,css_styled_content,...,...';
...['extList_FE'] = '...,...,hype_html5,css_styled_content,...,...';

All extensions which have FE plugins also need to
come after both extension regarding extList order.

You also need to include both static TS files from
hype_html5; but you should NOT include the static
TS file from css_styled_content, cause hype_html5
brings it's own content rendering TypoScript.

The docs of hype_html5 are up to date, so you could
also have a look at them regarding installation.

Thanks a lot!

Actions #3

Updated by Thomas Deinhamer almost 12 years ago

Is there a way of committing the change without fiddling around with setting up all the GIT/Gerrit stuff?

Would be really nice if someone could have a look and commit this as a bugfix for 4.5-6.0.

Thanks a lot!

Actions #4

Updated by Gerrit Code Review almost 12 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12748

Actions #5

Updated by Mario Rimann almost 12 years ago

Thomas Deinhamer wrote:

Is there a way of committing the change without fiddling around with setting up all the GIT/Gerrit stuff?

No, there's no way around Gerrit - but when you've set it up once, it's really easy to push changes to the review system. Just have a look at wiki.typo3.org where the standard steps are explained (or mail me if you need help)

Would be really nice if someone could have a look and commit this as a bugfix for 4.5-6.0.

I've now pushed your change for master (6.0) - and as soon as it is accepted/merged, it can be pushed for the maintenance branches.

Actions #6

Updated by Thomas Deinhamer almost 12 years ago

Awesome, thanks a lot!

I've taken some time in the past, to set up
GIT for TYPO3 on my Windows machine, but after
all it wasn't to easy, also due to lack of good
GIT clients for Windows; I'm not the best friend
of CLI/shell usage after all.

Also setting up a nice TYPO3 development environment
for multiple TYPO3 versions on Windows is quite
difficult/unhandy in my oppinion.

Maybe I have some time soon
to get more into the topic.

But thanks for your help anyway!

Actions #7

Updated by Gerrit Code Review over 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12748

Actions #8

Updated by Gerrit Code Review about 11 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/12748

Actions #9

Updated by Helmut Hummel almost 11 years ago

  • Status changed from Under Review to Needs Feedback

Thomas Deinhamer wrote:

If you install/use an extension which is installed before css_styled_content

What is the use case of having an extension being installed before css_styled_content? Since such an extension obviously wants to extend something of that extension, it obviously depends on it and thus has to be loaded after it. Am I missing anything?

Actions #10

Updated by Alexander Opitz about 10 years ago

  • Target version deleted (4.7.3)
  • Is Regression set to No

Hi,

as this issue is very old. Does the problem still exists within newer versions of TYPO3 CMS (6.1.7)?
And as Helmut Hummel wrote, this seams not the correct solution.

Actions #11

Updated by Alexander Opitz almost 10 years ago

  • Status changed from Needs Feedback to Closed

No feedback within the last 90 days => closing this ticket.

If you think that this is the wrong decision or experience this issue again, then please write to the mailing list typo3.teams.bugs with issue number and an explanation or open a new ticket and add a relation to this ticket number.

Actions #12

Updated by Mathias Brodala over 9 years ago

Maybe this one is related by/affects EXT:fluidcontent_core?

Actions

Also available in: Atom PDF