Feature #39578

Add whitespace between two tags when using stripHtml stdWrap

Added by Ingo Pfennigstorf 10 months ago. Updated 10 months ago.

Status:Under Review Start date:2012-08-07
Priority:Should have Due date:
Assignee:- % Done:

0%
Category:TypoScript
Target version:-
TYPO3 Version:6.0 Complexity:no-brainer
PHP Version:
Votes: 0

Description

Having a block like this :

page = PAGE
page.10 = TEXT
page.10.value = <li>Hello</li><li>World</li>
page.10.stripHtml = 1

results in an output "HelloWorld"

I suggest to put a whitespace between the closing and opening tag to get the proper output "Hello World"

I will provide a patch for this feature

History

#1
Updated by Gerrit Code Review 10 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13493

#2
Updated by Gerrit Code Review 10 months ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13493

#3
Updated by Ingo Pfennigstorf 10 months ago

If this breaks something, maybe it's smarter to add something like

page.10.stripHtml = 1
page.10.stripHtml.addWhitespaceBetweenTags = 1

and do not change the default behaviour.

What do you think?

#4
Updated by Oliver Klee 10 months ago

Even if we make this feature non-default, we still need unit tests to make sure that this change does not break anything. (In other words: Breaking things is not okay even if the feature is optional. :-)

#5
Updated by Ingo Pfennigstorf 10 months ago

I will surely add some unit tests that will be included in the next patchset

#6
Updated by Gerrit Code Review 10 months ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13493

#7
Updated by Gerrit Code Review 10 months ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13493

Also available in: Atom PDF