Bug #40855
closed
stdWrap of special.value in HMENU is applied twice
100%
Description
also appears in 4.5 and very likely 4.6
If the stdWrap functionality of HMENU.special.value is used, this is applied twice.
I'm not very familiar on how HMENU works internally. If someone could tell me the best place to fix this without side-effects, I would be happy to submit a patch.
Here are my findings:
The first time stdWrap is applied is tslib_content_HierarchicalMenu::render() (line 59 in TYPO3 4.5.19).
Then it is added multiple times accross tslib_menu again.
I would go with removing the stdWrapping in tslib_menu, but am I right with this or is there any other entry point to this class other than tslib_content_HierarchicalMenu::render() that I should check?
Updated by Markus Klein over 11 years ago
Hi!
Looking at the whole code here, all I can say: This is a complete mess!
After thinking about it a lot, it is somewhat impossible to move all the stdWraps of HMENU to the place where they actually belong, namely tslib_content_HierarchicalMenu.
One major problem is the fallback mechanism of minItems and maxItems.
Hence, the only chance to get this fixed is to remove the stdWrap from tslib_content_HierarchicalMenu.
Also excludeUidList should be moved to the place where it is used, to get at least some kind of consistency.
The stdWraps in tslib_menu are there since Nov. 2007 by Bernhard Kraft, whereas tslib_content_HierarchicalMenu exists only since Oct. 2010.
Updated by Jigal van Hemert over 11 years ago
- Status changed from New to Accepted
Updated by Gerrit Code Review over 11 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14588
Updated by Gerrit Code Review about 11 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/14588
Updated by Gerrit Code Review almost 11 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/14588
Updated by Gerrit Code Review almost 11 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/14588
Updated by Gerrit Code Review almost 11 years ago
Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/21686
Updated by Gerrit Code Review almost 11 years ago
Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/21687
Updated by Markus Klein almost 11 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 536857e31fe474e116e0f8b28e4be0567fe7fc33.
Updated by Gerrit Code Review almost 11 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/21738
Updated by Gerrit Code Review almost 11 years ago
Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/21739
Updated by Markus Klein almost 11 years ago
- Status changed from Under Review to Resolved
Applied in changeset 7afc40aa4968fae7b19a6f23b3fa2ff1106187c1.
Updated by