Bug #43216
closed
Deleted files are indicated in list
0%
Updated by
Updated by Andreas Wolf over 11 years ago
- Status changed from New to Needs Feedback
- Assignee deleted (
André Haehnel)
Thanks for the report, but I can't really locate the eroror - could you elaborate your description a bit more? What did you do, what was the expected result, what did you get instead? And a description of your environment would also help.
Updated by Rico Sonntag over 11 years ago
Deleted files unfortunately are still shown in the file list (but flagged inside db). They are not physically deleted.
https://review.typo3.org/#/c/16403/ fixes the missing delete-button and setting the deleted flag. but files are not deleted, either in the file list or detail view.
Updated by Christian Weiske over 11 years ago
Steps to reproduce:
- TYPO3 backend > File > Filelist
- Upload file
- File is shown in file list
- Edit file
- Delete file
- File is still shown in file list
Related to bug #42294.
Updated by Christian Weiske over 11 years ago
Part 1 of the problem is obtaining the information if the file is deleted or not. This is not directly available in TYPO\CMS\Core\Resource\File, but only in the index record.
Loading the index record is only possible by calling isIndexed(), since loadIndexRecord() is protected. Then, the deleted property is available.
Updated by Gerrit Code Review over 11 years ago
- Status changed from Needs Feedback to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17367
Updated by Gerrit Code Review over 11 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17367
Updated by Helmut Hummel over 11 years ago
- Status changed from Under Review to Rejected
Hi,
Christian Weiske wrote:
Steps to reproduce:
- TYPO3 backend > File > Filelist
- Upload file
- File is shown in file list
- Edit file
- Delete file
- File is still shown in file list
Cannot reproduce when using the context menu to delete the file.
Related to bug #42294.
If you use the delete button to delete the file which in implemented in this change, then this change is obviously wrong and should be fixed there.
Updated by Christian Weiske over 11 years ago
Sorry that I was unclear. I deleted it via "edit meta data" (edit icon) and then the delete icon. This set the record to "deleted".
So this is the problem we're trying to address here:
sys_filerecords that have thedeletedfield set to1are shown in the file list
The "delete" entry of the context menu actually removes the file, but keeps the record in sys_file as it is - it does not even set the record to "deleted", nor does it delete the record. This is wrong, too - IMO.
I think we need to wait for a resolution to the "how to delete a file" discussion in http://review.typo3.org/16403 until we can continue here.
Updated by Christian Weiske over 11 years ago
Helmut, Philipp Gampe thinks that records maked as deleted is something that needs to be supported - see http://lists.typo3.org/pipermail/typo3-dev/2013-January/046148.html
So in his eyes, this patch is actually useful. Could you please review it?
Updated by Dan Kleine (Untenzu) over 11 years ago
Just a quick note, maybe this is implemented already and im stepping in the wrong direction, but as I read about “automatic backups” and “no gos” for instant deletion in reviews and mailling lists: please keep in mind that editors should be able to remove a file and all it's relations instantly in case they are required to do so (e.g. due to an adhortatory letter, because of illegal usage of images).