Project

General

Profile

Actions

Bug #51486

closed

InstallSysExtsUpdate::installExtensions() incompatible AbstractUpdate::installExtensions()

Added by Tomasz Krawczyk over 10 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2013-08-29
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.1
PHP Version:
5.4
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

PHP Runtime Notice: Declaration of TYPO3\CMS\Install\CoreUpdates\InstallSysExtsUpdate::installExtensions() should be compatible with TYPO3\CMS\Install\Updates\AbstractUpdate::installExtensions($extensionKeys) in D:\wamp\www\typo3_src-6.1.3\typo3\sysext\install\Classes\CoreUpdates\InstallSysExtsUpdate.php line 38

Amount of parameters is different.

Actions #1

Updated by Philipp Gampe over 10 years ago

  • Status changed from New to Accepted

I think the overridding of the function was not intentional. Thus the function should berenamed to e.g. fetchAndInstallExtensions(...) in InstallSysExtsUpdate.

Could you push a patch to gerrit? http://wiki.typo3.org/CWT

Actions #2

Updated by Tomasz Krawczyk over 10 years ago

How whold you call InstallSysExtsUpdate::markWizardAsDone() ?

PHP Runtime Notice: Declaration of TYPO3\CMS\Install\CoreUpdates\InstallSysExtsUpdate::markWizardAsDone() should be compatible with TYPO3\CMS\Install\Updates\AbstractUpdate::markWizardAsDone($confValue = 1) in D:\wamp\www\typo3_src-6.1.3\typo3\sysext\install\Classes\CoreUpdates\InstallSysExtsUpdate.php line 38

I think PHP 5.3 allows on such overriding while PHP 5.4 does not.

PS. There are C++ programmers among us. ;-)

Actions #3

Updated by Tomasz Krawczyk over 10 years ago

The erroe message from my previous post shows after change InstallSysExtsUpdate::installExtensions to InstallSysExtsUpdate::fetchAndInstallExtensions.

Actions #4

Updated by Mathias Schreiber over 9 years ago

  • Status changed from Accepted to Needs Feedback
  • Assignee set to Mathias Schreiber
  • Is Regression set to No

Is this still the case on 6.2?

Actions #5

Updated by Tomasz Krawczyk over 9 years ago

I didn't see this in 6.2.

Actions #6

Updated by Mathias Schreiber over 9 years ago

  • Status changed from Needs Feedback to Closed

alrighty. Thanks for the feedback

Actions

Also available in: Atom PDF