Project

General

Profile

Actions
Copy link

Bug #51892

closed

LoginController::emitRenderLoginFormSignal does not add marker

Added by Sebastian Fischer over 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Sebastian Fischer
Category:
-
Target version:
-
Start date:
2013-09-10
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Currently its not possible to add marker in the emit. This is due to signals do no handle attributes by reference.

Actions
Copy link
 #1

Updated by Gerrit Code Review over 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23728

Actions
Copy link
 #2

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23728

Actions
Copy link
 #3

Updated by Gerrit Code Review over 10 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23728

Actions
Copy link
 #4

Updated by Gerrit Code Review over 10 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23728

Actions
Copy link
 #5

Updated by Sebastian Fischer over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #6

Updated by Anja Leichsenring over 10 years ago

  • Status changed from Resolved to Under Review

Reverted due to incomplete patch. If no signal is registered, the backend login only shows markers.

Actions
Copy link
 #7

Updated by Christian Kuhn over 10 years ago

Must be re-pushed, we reverted:

»···public function dispatch($signalClassName, $signalName, array $signalArguments = array()) {
»···»···$this->initializeObject();
»···»···if (!isset($this->slots[$signalClassName][$signalName])) {
»···»···»···return NULL;
»···»···}

-> if no signal is defined NULL is returned and not the former arguments ...

We reverted until it is cleared / changed that extbase does not return orig params if no slot is registered

Actions
Copy link
 #8

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24228

Actions
Copy link
 #9

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24228

Actions
Copy link
 #10

Updated by Gerrit Code Review over 10 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24228

Actions
Copy link
 #11

Updated by Sebastian Fischer over 10 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #12

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF