Project

General

Profile

Actions

Task #52043

closed

AbstractUserAuthentication::checkAuthentication fail to log unknown username

Added by Sebastian Fischer over 10 years ago. Updated over 10 years ago.

Status:
Rejected
Priority:
Should have
Category:
-
Target version:
-
Start date:
2013-09-16
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

If a user logs in with an unknown username the login try does not get logged. Based on this its not possible to display messages based on the count of failed logins. On the other side its possible to "guess" usernames be different behaviour of the loginscreen. Because of this it would be good to write a failed login to sys_log even with an unknown username.

Actions #1

Updated by Gerrit Code Review over 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23853

Actions #2

Updated by Thorsten Kahler over 10 years ago

  • Tracker changed from Bug to Feature
Actions #3

Updated by Sebastian Fischer over 10 years ago

Why was this issue declassified to only be a feature? By having no logging of unknown usernames the server reacts different and not only is a counting of failed logins due to unknown users is not possible but also other sidechannel attacks are possible.

From my point of view this is truly a bug and not a feature that is nice to have.

Actions #4

Updated by Markus Klein over 10 years ago

  • Tracker changed from Feature to Task
Actions #5

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23853

Actions #6

Updated by Christian Kuhn over 10 years ago

  • Status changed from Under Review to Rejected

not needed, information is already logged.

Actions

Also available in: Atom PDF