Bug #79045
closedgetTemplatePathAndFilename() in \TYPO3\CMS\Fluid\View\StandaloneView calls a non existing method
100%
Description
The method getTemplatePathAndFilename() in \TYPO3\CMS\Fluid\View\StandaloneView calls getTemplatePathAndFilename() on the TemplatePath. But this method doesn't exist neither in \TYPO3\CMS\Fluid\View\TemplatePaths nor in \TYPO3Fluid\Fluid\View\TemplatePaths
/** * Returns the absolute path to a Fluid template file if it was specified with setTemplatePathAndFilename() before * * @return string Fluid template path * @api */ public function getTemplatePathAndFilename() { return $this->baseRenderingContext->getTemplatePaths()->getTemplatePathAndFilename(); }
I had a conversation with Claus on Slack. He don't wan't to reimplement this method in \TYPO3Fluid\Fluid\View\TemplatePaths. He also will deprecate the setTemplatePathAndFilename() method there.
I think there are two solutions:- reimplement the getter-method in \TYPO3\CMS\Fluid\View\TemplatePaths
- remove the getter in \TYPO3\CMS\Fluid\View\StandaloneView
The second solution will be a breaking change in TYPO3 v8.
We should find a solution for that and mark both (getTemplatePathAndFilename() and setTemplatePathAndFilename()) as deprecated.
Updated by Gerrit Code Review over 7 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51004
Updated by Gerrit Code Review over 7 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51004
Updated by Gerrit Code Review over 7 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51004
Updated by Gerrit Code Review over 7 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51004
Updated by Gerrit Code Review over 7 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51004
Updated by Gerrit Code Review over 7 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51004
Updated by Daniel Gohlke over 7 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset c80b6747d0ef55a033adbc4a18801c4722dae8c9.
Updated by Riccardo De Contardi over 6 years ago
- Status changed from Resolved to Closed