Bug #89871: HrefLangGenerator: Wrong links generated with page translations that use a shortcut - TYPO3 Core - TYPO3 Forge

Custom queries

12 LTS
Accessibility
Dashboard issues
Easy tasks
Extbase Issues
FAL Issues
FAL Sprint 2023
Hierarchical Issues
Issues reported for v11
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
Most wanted Bugfixes
Most wanted Features
My open issues
New & Unassigned
No feedback within 90 days
Open Bugs
Open issues of 10
Page Tree Regressions after 2020-07-28
Recently modified
Regressions
Stabilization Issues
Usability or UX

Watchers (1)

Richard Haeser

Actions

Copy link

Bug #89871

closed

Epic #89797: HrefLang / Canonical issues

HrefLangGenerator: Wrong links generated with page translations that use a shortcut

Added by Christian Eßl over 4 years ago. Updated about 3 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Christian Eßl

Category:

Target version:

Start date:

2019-12-06

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

On Location Sprint

Description

Steps to reproduce:

- Create a site config with the languages "*Default*", "*German*", "*Spanish*"
- Create a page "Page A" and translate it to all languages
- Create a page "Page B" and translate it to all languages
- On "Page A", make the german translation to a "Shortcut" to "Page B"
- Now open the spanish version of "Page A".

Expected:
- The hreflang for "de" looks like https://www.sitename.com/de/page-b

Actual:
- The hreflang for "de" now looks like https://www.sitename.com/es/page-b
- This will also easily result in a 404 error, if the page title is different in the translation.

The HreflangGenerator incorrectly uses the language parameter of the current language instead of the one of the target language, if shortcuts are used.

Related issues 5 (0 open — 5 closed)

Related to TYPO3 Core - Bug #81657: TSFE->page contains default language page when content_fallback; 1,0 is used

Closed

2017-06-21

Actions

Related to TYPO3 Core - Bug #86595: No Language Fallback

Closed

Anja Leichsenring

2018-10-08

Actions

Related to TYPO3 Core - Bug #19114: sys_language_mode content_fallback with a defined fallback chain does not output expected fallback content

Closed

2008-07-16

Actions

Related to TYPO3 Core - Bug #94677: Menu-item of type "shortcut" is language-overlayed twice

Closed

2021-07-30

Actions

Related to TYPO3 Core - Task #95966: Wrong tests for #89871

Closed

2021-11-12

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Christian Eßl over 4 years ago

Description updated (diff)

Actions

Copy link

Updated by Christian Eßl over 4 years ago

Description updated (diff)

Actions

Copy link

Updated by Christian Eßl over 4 years ago

Found the reason:
https://github.com/TYPO3/TYPO3.CMS/commit/8d61bef0865649bbe3d73bdf77a47c760c8d9ba4

In this commit, shortcut pages are now generated with the setting "'language' => 'current',", which overrides the L parameter.

Actions

Copy link

Updated by Gerrit Code Review over 4 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62552

Actions

Copy link

Updated by Mathias Brodala over 4 years ago

Related to Bug #81657: TSFE->page contains default language page when content_fallback; 1,0 is used added

Actions

Copy link

Updated by Mathias Brodala over 4 years ago

Related to Bug #86595: No Language Fallback added

Actions

Copy link

Updated by Mathias Brodala over 4 years ago

Related to Bug #19114: sys_language_mode content_fallback with a defined fallback chain does not output expected fallback content added

Actions

Copy link

Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62552

Actions

Copy link

Updated by Christian Eßl over 4 years ago

Assignee set to Christian Eßl

Actions

Copy link

#10

Updated by Susanne Moog over 4 years ago

Sprint Focus set to On Location Sprint

Actions

Copy link

#11

Updated by Gerrit Code Review about 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62552

Actions

Copy link

#12

Updated by Gerrit Code Review about 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62552

Actions

Copy link

#13

Updated by Gerrit Code Review about 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62552

Actions

Copy link

#14

Updated by Gerrit Code Review about 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62552

Actions

Copy link

#15

Updated by Gerrit Code Review about 4 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62552

Actions

Copy link

#16

Updated by Gerrit Code Review almost 4 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62552

Actions

Copy link

#17

Updated by Richard Haeser over 3 years ago

Parent task set to #89797

Actions

Copy link

#18

Updated by Gerrit Code Review over 3 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62552

Actions

Copy link

#19

Updated by Gerrit Code Review over 3 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62552

Actions

Copy link

#20

Updated by Gerrit Code Review about 3 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67696

Actions

Copy link

#21