Task #97839: Extend PHP-CS-Fixer to avoid yoda style - TYPO3 Core - TYPO3 Forge

Custom queries

12 LTS
Accessibility
Dashboard issues
Easy tasks
Extbase Issues
FAL Issues
FAL Sprint 2023
Hierarchical Issues
Issues reported for v11
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
Most wanted Bugfixes
Most wanted Features
My open issues
New & Unassigned
No feedback within 90 days
Open Bugs
Open issues of 10
Page Tree Regressions after 2020-07-28
Recently modified
Regressions
Stabilization Issues
Usability or UX

Actions

Copy link

Task #97839

closed

Extend PHP-CS-Fixer to avoid yoda style

Added by Björn Jacob almost 2 years ago. Updated over 1 year ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Target version:

Start date:

2022-07-01

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Sprint Focus:

Description

The PHP-CS-Fixer config should be extended to avoid yoda style. ATM, there are 18 occurrences across the core. The problem was raised while reviewing https://review.typo3.org/c/Packages/TYPO3.CMS/+/74492/.

Related issues 1 (1 open — 0 closed)

Related to TYPO3 Core - Bug #87675: email2sender finisher: labels not translated correctly when override finisher settings is used

Under Review

2019-02-07

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Björn Jacob almost 2 years ago

Related to Bug #87675: email2sender finisher: labels not translated correctly when override finisher settings is used added

Actions

Copy link

Updated by Gerrit Code Review almost 2 years ago

Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75005

Actions

Copy link

Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75005

Actions

Copy link

Updated by Anonymous almost 2 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset 0fb53e0c5494c64797bb8f411168fc1962736124.

Actions

Copy link

Updated by Gerrit Code Review almost 2 years ago

Status changed from Resolved to Under Review

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75008

Actions

Copy link

Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75008

Actions

Copy link