Project

General

Profile

Actions
Copy link

Feature #99585

open

Add Upgrade Wizard for Apache htaccess files

Added by Oliver Hader over 1 year ago. Updated 9 months ago.

Status:
Accepted
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
Candidate for Major Version
Start date:
2023-01-17
Due date:
% Done:

0%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:
On Location Sprint

Description

  • (for instance)
  • check state of fileadmin/.htaccess and compare with current version provided in TYPO3
  • offer diff view and/or possibility to override or deny (for CLI)

Files

99585.png (82.4 KB) 99585.png Oliver Hader, 2023-01-23 18:19
Actions
Copy link
 #1

Updated by Oliver Hader over 1 year ago

  • Assignee set to Oliver Hader
Actions
Copy link
 #2

Updated by Christian Kuhn over 1 year ago

  • Status changed from New to Needs Feedback

The "Directory Status" module in the install tool was / is designed to deal with stuff like this.

Actions
Copy link
 #3

Updated by Oliver Hader over 1 year ago

That's how it the install tool current "deals with it" in TYPO3 v12...

Actions
Copy link
 #4

Updated by Benni Mack about 1 year ago

  • Target version changed from 12.2 to 12.3
Actions
Copy link
 #5

Updated by Benni Mack about 1 year ago

  • Target version changed from 12.3 to 12 LTS
Actions
Copy link
 #6

Updated by Benni Mack about 1 year ago

  • Target version changed from 12 LTS to Candidate for Major Version
Actions
Copy link
 #7

Updated by Oliver Hader about 1 year ago

  • Assignee deleted (Oliver Hader)

Would be a nice enhancement, but I don't have time for working on this...

Actions
Copy link
 #8

Updated by Oliver Hader about 1 year ago

  • Status changed from Needs Feedback to Accepted
Actions
Copy link
 #9

Updated by Benni Mack 9 months ago

  • Sprint Focus set to On Location Sprint
Actions
Copy link
 #10

Updated by Stephan Jorek 9 months ago

Hey folks,

after discussing a little bit with some core-devs (during the T3DD2023 coding-night), a wanted to sum up what we've analysed so far.

  1. Mark (.htaccess) file candidates that could be handled by this feature in TYPO3\CMS\Install\FolderStructure\DefaultFactory::getDefaultStructureDefinition()
  2. Update the implementation used in TYPO3\CMS\Install\Controller\EnvironmentController::folderStructureGetStatusAction() to show a green badge, if the marked files from (1.) are either unchanged or only contain (line-based) additions (but no changes).
    • This ensures that custom rules don't lead to false positives (ie. where rules have been added to public/.htaccess)
    • This should be implemented in TYPO3\CMS\Install\FolderStructure\FileNode, probably utilising sebastian/diff
  3. Update TYPO3\CMS\Install\FolderStructure\FileNode::fixSelf() adding a additional section which deals with changed files, propably by creating backup files and restoring the desired file contents
  4. Implement unit-tests to ensure the above changes are working
  5. Implement an update-wizard which utilises TYPO3\CMS\Install\FolderStructure\DefaultFactory to reset the changed files as described above. Of course after the user has given confirmation, probably after presenting a unified diff to the user first.
  6. Take care about the following implementations, which are using TYPO3\CMS\Install\FolderStructure\DefaultFactory
    • TYPO3\CMS\Install\Command\SetupCommand
    • TYPO3\CMS\Install\Controller\InstallerController
    • TYPO3\CMS\Install\Service\CoreUpdateService
Actions
Copy link

Also available in: Atom PDF