TYPO3 Core

Hey folks,

after discussing a little bit with some core-devs (during the T3DD2023 coding-night), a wanted to sum up what we've analysed so far.

1. Mark (.htaccess) file candidates that could be handled by this feature in TYPO3\CMS\Install\FolderStructure\DefaultFactory::getDefaultStructureDefinition()
2. Update the implementation used in TYPO3\CMS\Install\Controller\EnvironmentController::folderStructureGetStatusAction() to show a green badge, if the marked files from (1.) are either unchanged or only contain (line-based) additions (but no changes).
   • This ensures that custom rules don't lead to false positives (ie. where rules have been added to public/.htaccess)
   • This should be implemented in TYPO3\CMS\Install\FolderStructure\FileNode, probably utilising sebastian/diff
3. Update TYPO3\CMS\Install\FolderStructure\FileNode::fixSelf() adding a additional section which deals with changed files, propably by creating backup files and restoring the desired file contents
4. Implement unit-tests to ensure the above changes are working
5. Implement an update-wizard which utilises TYPO3\CMS\Install\FolderStructure\DefaultFactory to reset the changed files as described above. Of course after the user has given confirmation, probably after presenting a unified diff to the user first.
6. Take care about the following implementations, which are using TYPO3\CMS\Install\FolderStructure\DefaultFactory
   • TYPO3\CMS\Install\Command\SetupCommand
   • TYPO3\CMS\Install\Controller\InstallerController
   • TYPO3\CMS\Install\Service\CoreUpdateService