Bug #11572
closed
Creating new pages in the workspace creates the page also live
0%
Description
Creating new pages in the workspace creates the page also live,
meaning if I create a new page in a workspace and then switch to live the page is there, too (only hidden).
Files
Updated by Tolleiv Nietsch over 13 years ago
- File newpage.PNG newpage.PNG added
- Status changed from New to Needs Feedback
I'd say the data looks fine - there's a workspace-records and a placeholder both have a workspace-id - that's what we're supposed to see. I think this fact that the icon changed is more a GUI issue - so who can we blame for that?
thanks for keeping the eyes open :)
Updated by Susanne Moog over 13 years ago
I think we are talking about different things (or I don't understand you ;)). I've made a small screen capture so you can see what I mean: The page I create in a workspace should - as far as I understand - not be automatically created live, or should it?
Updated by Tolleiv Nietsch over 13 years ago
We're talking about the same thing - the page is actually not created in the live-workspace but there's a placeholder which (for some reason) shows up, although he is not supposed to be visible there. But the data itself is right - it's just that the page-tree shows that page also in the Live-workspace. - is there any chance we can move this issue to their bugtracker?
Updated by Susanne Moog over 13 years ago
I don't think it's a tree bug. I think it's more a core bug, but I'm not really sure because I don't know enough about workspaces yet. Should the function versioningPlaceholderClause (t3lib_befunc) take care of not showing initial placeholders?
Updated by Tolleiv Nietsch over 13 years ago
- File 11572.patch 11572.patch added
yes kind of - I see your point the attached patch fixes it for me. But I'm not sure if this can break anything else. Going to test that on Monday a bit more...
Updated by Susanne Moog over 13 years ago
- File 11572_v2.diff 11572_v2.diff added
Please have a look at my version, too - after thinking a bit about the function I think we don't need the if-statements at all and so far it's working that way for me :)
Updated by Peter Niederlag over 13 years ago
Old GUI way was to include and show NEW/MOVE PLACEHOLDERS (t3ver_state=1|3) in page-tree of live workspace. Wether showing or not showing them in the GUI is rather a matter of taste(seems nonsense to me, as updates/deletes were not shown) it is quite crucial to keep an eye on the underlaying API IMO. It might as well be useful/required to construct trees/lists for pages/other tables in a preview of a workspace. For this one does need to get those pages/data included (maybe even including applying pid and sorting properly). To me it seems like 'function versioningPlaceholderClause()' should maybe be capable to handle BOTH cases (boolean $includePlaceHolders)?
hth and many thx for your tremendous work! :->,
Peter
Updated by Sonja Schubert over 13 years ago
- Status changed from Needs Feedback to Accepted
- Target version set to 4.5 Beta 3
Updated by Tolleiv Nietsch over 13 years ago
- Target version changed from 4.5 Beta 3 to 4.5 RC1
Updated by Tolleiv Nietsch over 13 years ago
- Status changed from Accepted to Needs Feedback
@Susanne - your patch looks good for me and is working as expected, are you going to create the RFC?
@Peter - it's too late for an API change in 4.5, let's do that in 4.6 - hope that's fine for you?
Updated by Susanne Moog over 13 years ago
- Status changed from Needs Feedback to Under Review
http://bugs.typo3.org/view.php?id=17063 now pending in corelist
Updated by Susanne Moog over 13 years ago
- Status changed from Under Review to Resolved
Updated by Michael Stucki over 10 years ago
- Project changed from 624 to TYPO3 Core
- Category changed from Workspaces to Workspaces
- Target version deleted (
4.5 RC1)
Updated by 