TYPO3 Core

This first patch does the following:
- Made the docheader in alt_doc.php HTML-template based.
- Added a function to retrieve a HTML template from template.php that can be overriden by a skin.
- Rearranged the buttons in the top bar.

Next patch also covers the db_list
The db listing also has HTML template based docheader
Uses the same functionality as Benjamins.

very good work guys! anyways there's room for improvement =)... see attached screens

I'm still working on the docheader for page and template module. Hope I can get it in before feature freeze. Currently working on the page module docheader. Think it has more priority than template module.

Thanks for the improvements

thanks for letting me know Patrick. I'd allow the docheader to go into SVN even after beta1... just to let you know. Nevertheless it would be very welcome to have it with beta1.

Thanks Ingo. Page module is half way, so I expect everything to be ready before feature freeze

New patch has been added.

• Page
• List
• Template

There are some styling issues in IE which have to be solved. Icons are not at the right spot. Maybe Jens can have a look at the position of the icons.

• Info
• Access
• Functions
• Versioning

What should I do? Commit this first to trunk and add the missing module docheaders later, or shall we do it at once?

adding the missing ones later is ok with me

Hi Patrick, here're some more notes on the latest patch... good job!

Jeff Segars came with the request to put the 'Update' button in the docheader. This means the 'Cancel' button also has to go in there. I think the best solution is to use the appropriate icons for this.

Constant editor:
'savedok' icon instead of 'Update' button.
Now that I look at it the 'clear all cache' link can be deleted because this is already available in the top toolbar.

Info/Modify:
'savedok' icon instead of 'Update' button
'closedok' icon instead of 'Cancel' button
Same for 'clear all cache', should be deleted

Typoscript Object Browser:
Delete 'clear all cache'

Template analyzer:
No special remarks

Hi Patrick, here're some more (minor) suggestions

The icon after the text 'Viewing content of' is not redundant! The clickmenu of the page is connected to this icon. I don't think it is wise to remove the icon.

ok, didn't notice

(now what to do with this creepy icon?)

What's the current status on this? Any up to date patches available?

Last weekend I've rewritten some parts to make it more generic for each module. Currently I'm rewriting all core modules in 'Web' to use the docheader.

Hi,

This is a new patch.

The 'Web' modules 'Page', 'List', 'Info' and 'Access' and 'Template' now have the docheader.

Benni did HTML templating only for the docheader. Now the whole output for the modules has a template. The main output of the modules is put in the marker ###CONTENT###. I've done this for future purposes of the HTML templating of the BE modules.

The next few days I'm going to implement the docheaders for the modules 'Functions' and 'Versioning'.

After that I will implement functionality so every function module, added by an extension, can add their own buttons or other stuff to the docheader.

The HTML templates have to move to the modules own dedicated directories.

Ingo asked me to send this patch to core list, although this is not finished yet.

Patrick

i', sorry i couldn not patch my core with this diff..
i usually get it done simply with (when in trunk/ )
patch -p2 < ./20080204_rfc7262.diff
or
patch -p1 < ./20080204_rfc7262.diff

what the correct syntax with this diff? thanks

You are stripping of path levels. Simply use -p0

thanks patrick

i just made some checks and it seems very good!! (FF2 and Safari 3)

the only broken thing is the "back" button very far down, when i select a "new record" from the page module

thanks patrick

i just made some checks and it seems very good!! (FF2 and Safari 3)

the only broken thing is the "back" button very far down, when i select a "new record" from the page module

I know there are some issues with IE6. Whenever the page is too long, the scrollbar is not at the right spot in some modules. This is a CSS issue which I'm going to resolve.

Uploaded the changes for the docheader, splitted in to several patches.

20080205_rfc7262_base.diff: Base patch for template.php and stylesheet.css. Use this patch before applying any of the other patches.

20080205_rfc7262_page.diff: Web > Page module
20080205_rfc7262_list.diff: Web > List module
20080205_rfc7262_info.diff: Web > Info module
20080205_rfc7262_perm.diff: Web > Access module
20080205_rfc7262_func.diff: Web > Functions module
20080205_rfc7262_versioning.diff: Web > Versioning module
20080205_rfc7262_template.diff: Web > Template module

Docheader is tested in FF2, IE6, Opera9 and Safari3 on Windows

• Extra row has to be added to the docheader
• Version selector to extra row
• Searchbox (in list module) to extra row
• Record selector in Web > Page > Quickedit needs width (Adapts to the longest name which breaks the docheader)
• Save & Abort buttons Access > User overview to docheader as icons
• Refresh button Versioning to docheader as icon
• Searchbox (Template > TS Object browser) to extra row
• Styling of csh bubbles in docheader
• Extension module functions need to be able to add their own buttons and buttongroups to the docheader
• Move the html templates to the proper module locations
• Make these modules completely templatable
• Make html templates configurable for skin extensions

Stefano,

I can't reproduce this broken back button you are talking about. I've never touched this part of the page module, so it still works like it did before. In my installation it does exactly what it's supposed to do.

Patrick

Hi patrink.. it's not really "broken".. i see just a 400px empty vertical space between the records list and the button..

anyway later i try with your new patches!

thanks
s

I'd like to add the File -> Filelist to that list. Working on the patch today.

Hi Christoph,

Yeah, the plan is to add the docheader to other modules as well. But the first step has been made :-)

I am just saying I will work on the file list part :) It can be for beta2 if you want to push out beta1 fast, just saying I will work on that today.

Docheader has been committed to trunk for the latest patches.

@christoph -: Could you please make another RFC in the bugtracker for the file module? Otherwise this RFC is getting too big and covers too much. Add only RFC for the list module, please

Thanks

Committed to trunk