TYPO3 Core

Additional information - How to reproduce:
1.) Delete temp js files in typo3temp
2.) Create a Layer_menu with a code like this

page.20 = HMENU
page.20 {
    1 = TMENU_LAYERS
    1 {
      wrap=<table border="0" cellspacing="0" cellpadding="0">|</table>
      layerStyle = position:absolute;VISIBILITY:hidden;border: 1px solid #CCCCCC; background: #ffffff;

      lockPosition = y
      hideMenuWhenNotOver = 1
      hideMenuTimer=250
      expAll=1
      leftOffset = 0
      topOffset =22
      relativeToTriggerItem = 1

      NO {    
        allWrap=<td>|</td>
        ATagParams = class = "menue" 
      }
    }

    2 = TMENU
    2.NO {
      ATagParams = class = "menue1" 
      allWrap=|<br>
    }
}

Hi Georg,
thanks for the patch! I tried the generic one on Typo3 4.3 and unfortunately, js and css files are still being generated. Anything I can do to help troubleshoot this?

Hi @all review,

@Georg: Your patch differs from my original patch. Did it happen accidentally or was it your intent?
Frank:
md5('gl' ...
md5('tl' ...
Georg:
md5('tl' ...
md5('tl' ...

@Jörg: The patch was created when doing some research for an article in german T3N magazine. Are you sure that the patch did succeed without any error? Is it possible that the class files are cached in any way and the cached files and not the patched files are used? Can you give me some examples of js filenames? There may be still another bug which affects also css files. Then there will be more research needed.

regards,
Frank

Hi Frank,

I think I had a caching problem after applying the patch before. Now, no more .js files are accumulated, thanks again!

Hi @all review,
it looks like nobody cares about this bug. Maybe there should be more users with 2 million .js files in typo3temp like posted on twitter a few days before. ;-)

Hint: If your typo3temp is grown and you have to delete many thousands of files then the small linux-tools "direntries" (part of the sac-tools software suite) may be useful for you.
Example: direntries -D -e .js typo3temp
It will delete the .js files faster than any other tool on linux.

A new patch is available.
As an additional string for creating the ID a serialized representation of the menu array variable menuArr is used.

See also http://bugs.typo3.org/view.php?id=13886

the patch for 4.2.9 worked for me on 4.2.6
the patch for 4.3.2 did not work for me though on 4.3.2

Should anything else be applied together with this patch(s)?

@Vahan:
Please try the simplified patch typo3-4.3.2-no-typo3temp-fill-with-javascript-3.patch.
Compare the patched files with their originals to see the small difference.

The patch should fit for all TYPO3 versions (with a little offset).

I thought this was already fixed in Typo3 4.4(x). Now I just realized that after updating, I had another 4600 .js files in my temp folder...

Hi guys,

please send a reminder to the thread in Core List, so that this problem gets a bit more attention.

Thank you!

I've used typo3-4.3.2-no-typo3temp-fill-with-javascript-3.patch on Typo3 4.4.2 and it doesn't seem to have any effect. Anybody else?

Hi Jorgo,
on 2009-12-14 you wrote that you already had a "caching problem" (solved).
Now we try it again. :-)
1) Did you verify that the files are actually patched?
2) Are you sure that there are no copies of these on other places installed and "activated"?
3) Did you check for Bug #22311?
4) Do you use GTMENU (http://wiki.typo3.org/wiki/GTMENU)?
If you can't solve it please post the last few lines of an example typo3temp/*.js file.
I've successfully patched hundreds of TYPO3 installations.
Frank

I have just bumped the core list with a new CGL version of the patch after my testing of v3. Let's hope this one gets solved soon. It certainly have waited long enough. Will attach the patch here for reference.

committed to svn
4_2 rev 9035
4_3 rev 9036
4_4 rev 9037
trunk rev 9038

As per various posts of mine in the newsgroups, I had advised that

In my typo3 4.4.4 there are 2 identical versions of the script. One
resides in
\typo3\sysext\cms\tslib\media\scripts\
and this is where the patch header points to.

Another version resides in
\typo3\sysext\statictemplates\media\scripts\
and only after I had patched those files as well did the creation of
new .js files stop.

Also, in Typo3 4.5.3, different (older) versions of the files than in 4.5.2 seem to have been included.

I've advised about this bug in the Bug Day Wiki http://wiki.typo3.org/BugDay/201105, in the newsgroups and here, yet nobody seems to want to fix it as 4.5.4 came out with it AGAIN.

why not using md5(json_encode($config_array)) as name for the js file?! this way you would only get a new file, if the config changes.

I have not spent time to digg into the issue's code, but i think this could be a solution

Regards
Kay

To be honest, I don't exactly understand the problem (at least not under which circumstances it exists).

What's with the option layer_menu_id? Does that help?

The patch mentioned here was obviously only applied to the file in cms/tslib/, but not in statictemplates/. But, if I don't get you wrong, this one doesn't work, too?

Example code by Sergey Alexandrov:

page.includeLibs.tmenu_layers=media/scripts/tmenu_layers.php
temp.topmenu=HMENU
temp.topmenu {
  1 = TMENU_LAYERS
  1 {
    expAll=1
    relativeToTriggerItem=1
    relativeToTriggerItem.addHeight=1
    displayActiveOnLoad=0
    freezeMouseover=1
    hideMenuWhenNotOver=1
    topOffset=15
    wrap = <tableborder="0"cellpadding="0"cellspacing="0"class="level1"align="center"><tr>|</tr></table>
    NO.allWrap = <tdclass="level1"align="left">|</td>
  }

  2 = TMENU_LAYERS
  2 {
    hideMenuWhenNotOver=1
    wrap=<tableborder="0"cellpadding="0"cellspacing="0"class="level2">|</table>
    NO.allWrap=<tr><tdclass="level2">|</td></tr>
  }
}

I still cannot reproduce this. What's the difference between all these files' contents?

Wow... 2 years of nothing and then this is what the community gets? What about the 4.x versions???

Just for reference in case somebody still has this problem with TYPO3 4. The patches disscussed here did work in our case.
We actually did set the tmenu_layers and gmenu_layers script excplicitely, so there is no issue with different locations of that scripts among different TYPO3 versions.

page.includeLibs.tmenu_layers=...

This worked for almost a year but today for some reason we had double function definitions caused by the same identifier generated twice inside the DHTML menu JavaScript code.
Now the Menu didn't work as expected and some layers just didnt got hidden on mouse out.

To fix this again without too much digging I just changed the critcal line of code from this

 $this->WMid = trim($this->mconf['layer_menu_id'])?trim($this->mconf['layer_menu_id']).'x':substr(md5('tl'.serialize($this->result)),0,6);

to this

$this->WMid = trim($this->mconf['layer_menu_id'])?trim($this->mconf['layer_menu_id']).'x':substr(md5('tl'.serialize($this->result).$this->id),0,6);

Now it works again.