Project

General

Profile

Actions
Copy link

Feature #23493

closed

adding second parameter to $hookObj->execFinalQuery_idList

Added by Adrian Föder over 13 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2010-09-02
Due date:
% Done:

0%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

in extension's pi class, there are the lines

// Calling hook for alternative creation of page ID list
        if ($hookObj = $this->hookRequest('execFinalQuery_idList')) {
            $page_where = $hookObj->execFinalQuery_idList($list);
        }

It would be very useful to add '$page_join' as second parameter, so that it reads

$page_where = $hookObj->execFinalQuery_idList($list, $page_join);

The second parameter then could be passed by reference and modified at the hook's inside function.
It makes sense to allow not only the modification of $page_where but also $page_join.

Another possibility to make sure downward compatibility could be something like

$hookRet = $hookObj->execFinalQuery_idList($list);
            if(is_array($hookRet)) {
                list($page_where, $page_join) = $hookRet
            } else { 
                $page_where = $hookRet;
            }

Best,
Adrian

(issue imported from #M15623)

Actions
Copy link

Also available in: Atom PDF