Project

General

Profile

Actions

Bug #76923

closed

Suggest wizard on group field (with multiple true) adds element twice (maybe only in flexforms)

Added by Andreas Allacher almost 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2016-07-04
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

If one adds a group field to flexform like this:

<settings.test>
                        <TCEforms>
                            <label>Test</label>
                            <config>
                                <type>group</type>
                                <internal_type>db</internal_type>
                                <allowed>tx_test_domain_model_test</allowed>
                                <size>1</size>
                                <maxitems>9999</maxitems>
                                <minitems>1</minitems>
                                <multiple>1</multiple>
                                <autoSizeMax>30</autoSizeMax>
                                <size>10</size>
                                <show_thumbs>1</show_thumbs>
                                <wizards>
                                    <suggest>
                                        <type>suggest</type>
                                    </suggest>
                                </wizards>
                            </config>
                        </TCEforms>
                    </settings.test>

Results in element being added twice when using mouse click to select.
The issue does not exist when using keyboard Enter key.

The reason seems to be that it is added once via onSelect handler of autocomplete and once via the manual click handler.
Not sure if the manual click handler is actually necessary or if removing it would be a regression elsewhere.

Actions #1

Updated by Andreas Allacher almost 8 years ago

Seems to also be an issue with selectSideBySide (at least for flexform fields)

Tested with 7.6.9

Actions #2

Updated by Frank Nägler almost 8 years ago

  • Assignee deleted (Frank Nägler)
Actions #3

Updated by Gerrit Code Review almost 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49212

Actions #4

Updated by Gerrit Code Review almost 8 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49223

Actions #5

Updated by Alexander Opitz almost 8 years ago

Is #72738 eventually a duplicate of this one?

Actions #6

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49223

Actions #7

Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49223

Actions #8

Updated by Gerrit Code Review over 7 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49862

Actions #9

Updated by Wiard van Rij over 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #10

Updated by Christian Kuhn over 7 years ago

example group_db_8 added to styleguide for this one.

Actions #11

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF