TYPO3 Core

Thank you for your report. This is an unfortunate shortcoming of Fluid at the moment, see: https://github.com/TYPO3/Fluid/issues/911

For now, we probably need to re-implement boolean behavior manually for the arguments that were previously registered as boolean, although it makes things more inconsistent in templates…

Since the migration to the new behaviour is easy once the problem is known, I think it would be sufficient to document the new behaviour or record it in the changelog instead of increasing complexity/inconsistency.

Thanks for the patch. I can confirm that the former behaviour is restored with this PR #940 (based on the main branch) of the typo3fluid/fluid package.

In addition, I have tested whether there was/is any form of interpretation of the values.

The following values were tested in TYPO3 12.4.16, 13.2.1 and 13.3.0-dev:

<f:form.textarea name="myname" value="myvalue" readonly="1" />
<f:form.textarea name="myname" value="myvalue" readonly="0" />
<f:form.textarea name="myname" value="myvalue" readonly="readonly" />
<f:form.textarea name="myname" value="myvalue" readonly="true" />
<f:form.textarea name="myname" value="myvalue" readonly="false" />

<textarea readonly="1" name="myname">myvalue</textarea>
<textarea readonly="0" name="myname">myvalue</textarea>
<textarea readonly="readonly" name="myname">myvalue</textarea>
<textarea readonly="true" name="myname">myvalue</textarea>
<textarea readonly="false" name="myname">myvalue</textarea>

So now it's safe. The only difference was the different handling of the empty value, which is fixed by your patch. Any other value is transferred directly to the HTML output in all tested versions.

Thanks to Garvin's input we found a few more edge cases, which should now also be handled properly: Passing true, false, null and a undefined variable directly to the ViewHelper, not as string.

Could you check if the linked PR still works for you?

I ran the above tests again with the latest version of the PR. Your changes to the PR had no effect on the results already mentioned.

At Garvin's request, I also tested the following scenarios in TYPO3 13.3.0-dev:

{f:form.textarea(name: 'myname', value: 'value', readonly: 'readonly')}
{f:form.textarea(name: 'myname', value: 'value', readonly: variableTrue)}
{f:form.textarea(name: 'myname', value: 'value', readonly: variableFalse)}
{f:form.textarea(name: 'myname', value: 'value', readonly: variableNull)}
{f:form.textarea(name: 'myname', value: 'value', readonly: notDefinedVariable)}

with the following assignments in the Extbase Controller:

$this->view->assign('variableTrue', true);
$this->view->assign('variableFalse', false);
$this->view->assign('variableNull', null);

With the current main branch of typo3fluid/fluid I get the following HTML results:

<textarea readonly="readonly" name="myname">value</textarea>
<textarea readonly="1" name="myname">value</textarea>
<textarea readonly="" name="myname">value</textarea>
<textarea readonly="" name="myname">value</textarea>
<textarea readonly="" name="myname">value</textarea>

With latest version of your patch #940 I get the following HTML results:

<textarea readonly="readonly" name="myname">value</textarea>
<textarea readonly="1" name="myname">value</textarea>
<textarea readonly="" name="myname">value</textarea>
<textarea name="myname">value</textarea>
<textarea name="myname">value</textarea>

therefore the case of a "real" FALSE value still seems to lead to the output of the attribute with an empty value.

BUT we also have this behaviour in TYPO3 12.4.16 (also tested)!

Accordingly, we can state that the inline notation with the cases mentioned are also set to the original behaviour by the patch, even if it seems a bit illogical that TRUE becomes 1 and FALSE becomes an empty value instead of 0 or an attribute not set.

Many, many thanks to you both for working this out. This saved at least one of our projects from a possibly gritty v12 patchlevel update. 👏

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85420

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85420