Project

General

Profile

Actions

Task #105109

closed

Remove superflous is_string check in EnvVariableProcessor

Added by Sascha Egerer 2 months ago. Updated 2 months ago.

Status:
Rejected
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2024-09-25
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The function parameter is typed as string so there is no need for a "is_string" check

Actions #1

Updated by Gerrit Code Review 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86306

Actions #2

Updated by Gerrit Code Review 2 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86306

Actions #3

Updated by Sascha Egerer 2 months ago

  • Status changed from Under Review to Rejected

Class does not use strict_types yet so the type check is still required.

Actions

Also available in: Atom PDF