Project

General

Profile

Actions

Bug #15290

closed

wizard_colorpicker.php doesn't work properly in FlexForms

Added by David Bruehlmeier over 18 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2005-12-16
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
3.8.0
PHP Version:
4
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When using wizard_colorpicker.php in FlexForms, the picked colors are only displayed properly before saving the form. Afterwards, the color always changes to something purple (in IE) or background color (grey, in Firefox). Additionally, IE shows some flickering mousovers when pointing over the colorbox. Firefox shows all of the FlexForm XML in the mouseover.

Snippet from the FlexForm XML:

<fg_color_field_names>
<TCEforms>
<label>LLL:EXT:partner/locallang.php:tx_partner.label.xls.fg_color_field_names</label>
<config>
<type>input</type>
<size>10</size>
<wizards>
<colorpick>
<type>colorbox</type>
<title>LLL:EXT:partner/locallang.php:tx_partner.label.color_picker</title>
<script>wizard_colorpicker.php</script>
<dim>20x20</dim>
<tableStyle>border: solid 1px black; margin-left: 20px;</tableStyle>
<JSopenParams>height=550,width=365,status=0,menubar=0,scrollbars=1</JSopenParams>
<exampleImg>gfx/wizard_colorpickerex.jpg</exampleImg>
</colorpick>
</wizards>
</config>
</TCEforms>
</fg_color_field_names>
(issue imported from #M2052)


Files

colorpicker_flexforms.png (5.72 KB) colorpicker_flexforms.png Administrator Admin, 2005-12-16 19:55
bugfix_2052.txt (1.13 KB) bugfix_2052.txt Administrator Admin, 2005-12-21 19:08
testext_bug2052.t3x (10.6 KB) testext_bug2052.t3x Administrator Admin, 2005-12-21 19:08
bugfix2052_updated.txt (1.11 KB) bugfix2052_updated.txt Administrator Admin, 2006-07-07 22:17
T3X_bug2052-0_0_0-z-200607072217.t3x (10.6 KB) T3X_bug2052-0_0_0-z-200607072217.t3x Administrator Admin, 2006-07-07 22:17
Actions #1

Updated by Sebastian Kurfuerst over 18 years ago

Hi,
is it possible for you to locate the problem and write a patch for it?

Greets from Dresden,
Sebastian

Actions #2

Updated by David Bruehlmeier over 18 years ago

Hi Sebastian

The bug is in class.t3lib_tceforms.php, function renderWizards() on the lines 2997 and 3002 (based on CVS-version 1.66). The color of the colorbox is taken from $row[$field], which is an XML structure if the field is a FlexForm-field. The attached fix changes this and takes the value from $PA['itemFormElValue'] instead, which is the proper value even if it comes from a FlexForm field.

The t3x-file is a small extension which includes two fields with a colorpicker-wizard, one being a regular field and one being an FlexForm-field. That's how I tested the bugfix.

Greetings from snowy Switzerland! :-)
Dave.

Actions #3

Updated by David Bruehlmeier almost 18 years ago

Hi,

the problem has not been resolved yet (just tested it with 4.0). I have updated the patch for TCE-forms which is now based on SVN revision 1603 and I have made a small change to the test extension.

Greetings,
Dave.

Actions #4

Updated by Steffen Kamper almost 17 years ago

Why is this bugfix not implemented in svn ?

Changing this 2 lines works fine (tested with 4.2dev) !

vg Steffen

Actions #5

Updated by Andreas Otto † almost 17 years ago

This bug has been fixed now in SVN in trunk, 4.1 and 4.0.

Actions

Also available in: Atom PDF