Project

General

Profile

Actions

Bug #19282

closed

declare marker handling functions of t3lib_parsehtml static

Added by Ingo Renner over 15 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2008-09-03
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.3
PHP Version:
4.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Problem:
1) The marker handling functions in t3lib_parsehtml are often called staticaly although there're not declared static (even is the case within t3lib_parsehtml itself).
According to http://ilia.ws/files/ez_performance.pdf this results in a drop of performance, other than that it produces notices or warnings and it is not good in general of course.

2) There's an inconsistency: although a method substituteMarkerArray() exists, there's no substituteSubpartArray()

Solution:
1) Declare those methods static
2) introduce the missing method substituteSubpartArray()

Notice:
There's also some cleanup in t3lib_parsehtml and tslib_content. No functionality has been changed except for the addition of the new method in t3lib_parsehtml

(issue imported from #M9283)


Files

t3lib_parsehtml-cleanup.diff (22.8 KB) t3lib_parsehtml-cleanup.diff Administrator Admin, 2008-09-03 20:57

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Feature #19446: substituteMarkerArrayCached is too strict for older extensionsClosedErnesto Baschny2008-10-10

Actions
Actions #1

Updated by Ingo Renner over 15 years ago

committed to trunk

Actions

Also available in: Atom PDF