Project

General

Profile

Actions
Copy link

Bug #22361

closed

PageRenderer renderJsLibraries should be after the hook

Added by Steffen Kamper over 14 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Steffen Kamper
Category:
-
Target version:
-
Start date:
2010-03-31
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.4
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If you want to manipulate ExtOnReady code or the js libs, the hook is too late.

Easy to solve, move the call $this->renderJsLibraries() behind the hook.

(issue imported from #M13980)

Files

13980.diff (881 Bytes) 13980.diff Administrator Admin, 2010-03-31 18:23
Actions
Copy link
 #1

Updated by Steffen Kamper over 14 years ago

Just to show before/after

before in hook:

$parameters['jsLibsCore'] = str_replace('TYPO3.Backend = new TYPO3.Viewport(TYPO3.Viewport.configuration);',
    'Ext.apply(TYPO3.Viewport.configuration.items[1], {
        split: true,
        collapsable: true,
        collapseMode: \'mini\',
        hideCollapseTool: true,
        animCollapse: false
    });
TYPO3.Backend = new TYPO3.Viewport(TYPO3.Viewport.configuration);',
$parameters['jsLibsCore']);

and after:

$pageRenderer->addExtOnReadyCode(" 
    Ext.apply(TYPO3.Viewport.configuration.items[1], {
        split: true,
        collapsable: true,
        collapseMode: 'mini',
        hideCollapseTool: true,
        animCollapse: false
    });
", TRUE);

which is definitive the cleaner solution

Actions
Copy link
 #2

Updated by Steffen Kamper over 14 years ago

committed to svn,
4_3 rev 7231
trunk rev 7232

Actions
Copy link

Also available in: Atom PDF