TYPO3 Core

Patch works very well for me. +1 by reading and testing

Hi,

I tested it and it works in the frontend if I'm not in the workspace in the backend.

When I'm in the workspace in the backend, it breaks again.

Is it really usefull to have a "echo" there? Wouldn't it be better to have some kind of wrapper? I didn't figure out where it has to be put to work properly, at the end of the body doesn't seam to work. Can someone check where the javascript has to be to work properly?

Greets

Tizian

Maybe there should be checked if the frontend mode is the workspace frontend preview, is this possible?

Currently I fixed it with this:

if ($pObj->fePreview != 2 || $pObj->whichWorkspace() === 0 || !t3lib_div::_GP('tx_workspaces_web_workspacesworkspaces')) {
    return;
}

This may be the solution but I think there is a possibility to know in which frontend mode we are and it should probably be checked with this an not with this "ugly" fix.

nope t3lib_div::_GP('tx_workspaces_web_workspacesworkspaces') is always true in that context ;) - atm. we can't distinguish between standalone or "within preview window"

the "echo" is replaced in #13446 - please see https://review.typo3.org/#change,1058 for the latest patch update