Bug #26133: Fix broken string replacement for media/ folder - TYPO3 Core - TYPO3 Forge

Custom queries

12 LTS
Accessibility
Dashboard issues
Easy tasks
Extbase Issues
FAL Issues
FAL Sprint 2023
Hierarchical Issues
Issues reported for v11
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
Most wanted Bugfixes
Most wanted Features
My open issues
New & Unassigned
No feedback within 90 days
Open Bugs
Open issues of 10
Page Tree Regressions after 2020-07-28
Recently modified
Regressions
Stabilization Issues
Usability or UX

Watchers (1)

Patrick Rodacker

Actions

Copy link

Bug #26133

closed

Fix broken string replacement for media/ folder

Added by Patrick Rodacker about 13 years ago. Updated over 9 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Target version:

Start date:

2011-04-19

Due date:

% Done:

Estimated time:

TYPO3 Version:

4.5

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

The function setAbsRefPrefix() of the class tslib_fe includes the following string replacement, which is obsolete and should be removed.

$this->content = str_replace('"media/', '"'.t3lib_extMgm::siteRelPath('cms').'tslib/media/', $this->content);

Related issues 3 (0 open — 3 closed)

Related to TYPO3 Core - Bug #25028: Remove cms/tslib/media folder to TER extension

Closed

2011-02-14

Actions

Related to TYPO3 Core - Bug #25985: remove obsolete check for dir media/scripts/ in Function tslib_fe::checkFileInclude

Closed

2011-04-15

Actions

Related to TYPO3 Core - Task #28024: Remove tslib/media, cglify statictemplates/media

Closed

2011-07-09

Actions

Issue # Delay: days Cancel

History
Notes
Property changes

Actions

Copy link

Updated by Mr. Hudson almost 13 years ago

Patch set 1 of change Ie9736d815308c20f609f58da2cda735dcdc0a037 has been pushed to the review server.
It is available at http://review.typo3.org/2363

Actions

Copy link

Updated by Susanne Moog almost 13 years ago

Status changed from New to Under Review

Actions

Copy link

Updated by Patrick Rodacker almost 13 years ago

From Gerrit:

Susanne Moog        May 24
Patch Set 1: I would prefer that you didn't submit this
As far as I can see we should not remove the replacement as TYPO3 core still 
allows the media/ folder as valid place for storing scripts and media files 
(see t3lib_tstemplate for example) - if someone is still using that directory 
for file inclusion this patch will break paths if absRefPrefix is used.
We should deprecate the inclusion of files in the media folder first.

How do we deprecate the inclusion from the media/ folder first?

I read in another post, that a htaccess file with an AJAX call to write the log could be used.

Actions

Copy link

Updated by Steffen Gebert over 12 years ago

Status changed from Under Review to Rejected

Actions

Copy link

Updated by Steffen Gebert over 12 years ago

Status changed from Rejected to Under Review

Actions

Copy link

Updated by Chris topher almost 12 years ago

Now this folder has been removed from the TYPO3 Core. The replacement, which you quoted above, is still there and will not work anymore. Instead the files from statictemplates/media should be used.

Actions

Copy link

Updated by Chris topher almost 12 years ago

Subject changed from remove obsolete string replacement for media/ folder in tslib_fe::setAbsRefPrefix to Fix broken string replacement for media/ folder
Target version set to 6.0.0-pre-beta1

Actions

Copy link