Project

General

Profile

Actions
Copy link

Bug #32238

closed

Bugfix #28952 breaks sections in flexforms

Added by Mathias Schreiber over 12 years ago. Updated about 12 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Tolleiv Nietsch
Category:
Backend API
Target version:
4.5.12
Start date:
2011-12-01
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
5.2
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

The above bugfix breaks Flexforms sections.
The problem is due to the fact that the added decodeURIComponent() tries to decode an already decoded URI, resulting in a javascript error "Malformed URI sequence".

To reproduce use the attached flexform.

Files

flexform_pi2.xml (3.51 KB) flexform_pi2.xml Mathias Schreiber, 2011-12-01 13:15

Related issues 3 (0 open — 3 closed)

Related to TYPO3 Core - Bug #28952: Flexform shows utf8-labels and options not correctlyClosed2011-08-12

Actions
Related to TYPO3 Core - Bug #33377: Javascript error: URI malformed when adding new sectionsClosed2012-01-23

Actions
Is duplicate of TYPO3 Core - Bug #32422: Encoding error in TCEforms inline JavaScriptClosedSteffen Gebert2011-12-09

Actions
Actions
Copy link
 #1

Updated by Stefan Rotsch over 12 years ago

Removing the obsolete call of unescape() on the already decoded output of decodeURIComponent() makes JS links on Flexform sections work again for me without re-introducing the bug mentioned in #28952.

I submitted a patch to review.typo3.org. As this is my first attempt of contribution, please be patient with me if I made any formal mistakes.

Actions
Copy link
 #2

Updated by Gerrit Code Review over 12 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7468

Actions
Copy link
 #3

Updated by Ernesto Baschny over 12 years ago

The solution seems fine as the unescape() is really superfluous. Please also consider bug #33377, which adds yet another layer of complexity, at least for TYPO3 4.5 LTS, where we also want to support non UTF-8 based backends. Any idea?

Actions
Copy link
 #4

Updated by Ernesto Baschny over 12 years ago

  • Target version changed from 4.5.9 to 4.5.12
Actions
Copy link
 #5

Updated by Gerrit Code Review about 12 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/8885

Actions
Copy link
 #6

Updated by Helmut Hummel about 12 years ago

  • Status changed from Under Review to Closed

closed as duplicate

Actions
Copy link

Also available in: Atom PDF