Project

General

Profile

Actions

Bug #100070

closed

Invalid HTML a tag generation in due to missing quote DatabaseRecordList

Added by Joey Bouten about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
Start date:
2023-03-03
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
8.0
Tags:
DatabaseRecordList
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

All titles are broken in our list view.

            default:
                // Output the label now:
                if ($table === 'pages') {
                    $code = '<a href="' . htmlspecialchars(
                        $this->listURL((string)$uid, '', 'pointer')
                    ) . '>' . $code . '</a>';
                } else {
                    $code = $this->linkUrlMail($code, $origCode);
                }

Should be

            default:
                // Output the label now:
                if ($table === 'pages') {
                    $code = '<a href="' . htmlspecialchars(
                        $this->listURL((string)$uid, '', 'pointer')
                    ) . '">' . $code . '</a>';
                } else {
                    $code = $this->linkUrlMail($code, $origCode);
                }

Generated code is :<a href="/typo3/module/web/list?token=TOKEN&amp;id=13910&amp;table=>Crops - folder</a>

should be:

Generated code is :<a href="/typo3/module/web/list?token=TOKEN&amp;id=13910&amp;table=">Crops - folder</a>

Breaking change was done in: https://github.com/TYPO3-CMS/recordlist/commit/2829fb9c44b27a3f285620ff2b02480bfb0d3814


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #94762: Introduce ModuleStateStorage replacing fsModClosed2021-08-09

Actions
Actions #1

Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78013

Actions #2

Updated by Nikita Hovratov about 1 year ago

  • Related to Task #94762: Introduce ModuleStateStorage replacing fsMod added
Actions #3

Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78015

Actions #4

Updated by Joey Bouten about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF