Project

General

Profile

Actions
Copy link

Bug #100533

closed

Restrict table-fit last-row border removal

Added by Benjamin Kott over 1 year ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2023-04-08
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Files

Download all files
tables-bordered-after.png (62.6 KB) tables-bordered-after.png Benjamin Kott, 2023-04-08 08:52
tables-after.png (52.5 KB) tables-after.png Benjamin Kott, 2023-04-08 08:52
tables-bordered-before.png (62.8 KB) tables-bordered-before.png Benjamin Kott, 2023-04-08 08:55
tables-before.png (52.5 KB) tables-before.png Benjamin Kott, 2023-04-08 08:55
Actions
Copy link
 #1

Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78543

Actions
Copy link
 #2

Updated by Benjamin Kott over 1 year ago

  • File borders-current.png added
  • File borders-desired.png added
Actions
Copy link
 #3

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78543

Actions
Copy link
 #4

Updated by Benjamin Kott over 1 year ago

  • File deleted (borders-current.png)
Actions
Copy link
 #5

Updated by Benjamin Kott over 1 year ago

  • File deleted (borders-desired.png)
Actions
Copy link
 #8

Updated by Benjamin Kott over 1 year ago

Test Markup

<div class="p-5">
    <h2>Table</h2>
    <div class="table-fit">
        <table class="table table-hover">
            <thead>
                <tr>
                    <th scope="col">#</th>
                    <th scope="col">First</th>
                    <th scope="col">Last</th>
                    <th scope="col">Handle</th>
                </tr>
            </thead>
            <tbody>
                <tr>
                    <th scope="row">1</th>
                    <td>Benjamin</td>
                    <td>Kott</td>
                    <td>@benjaminkott</td>
                </tr>
                <tr>
                    <th scope="row">2</th>
                    <td>TYPO3</td>
                    <td></td>
                    <td>@typo3</td>
                </tr>
            </tbody>
        </table>
    </div>

    <h2>Table with caption</h2>
    <div class="table-fit">
        <table class="table table-hover">
            <caption>List of users</caption>
            <thead>
                <tr>
                    <th scope="col">#</th>
                    <th scope="col">First</th>
                    <th scope="col">Last</th>
                    <th scope="col">Handle</th>
                </tr>
            </thead>
            <tbody>
                <tr>
                    <th scope="row">1</th>
                    <td>Benjamin</td>
                    <td>Kott</td>
                    <td>@benjaminkott</td>
                </tr>
                <tr>
                    <th scope="row">2</th>
                    <td>TYPO3</td>
                    <td></td>
                    <td>@typo3</td>
                </tr>
            </tbody>
        </table>
    </div>

    <h2>Table with caption top</h2>
    <div class="table-fit">
        <table class="table table-hover caption-top">
            <caption>List of users</caption>
            <thead>
                <tr>
                    <th scope="col">#</th>
                    <th scope="col">First</th>
                    <th scope="col">Last</th>
                    <th scope="col">Handle</th>
                </tr>
            </thead>
            <tbody>
                <tr>
                    <th scope="row">1</th>
                    <td>Benjamin</td>
                    <td>Kott</td>
                    <td>@benjaminkott</td>
                </tr>
                <tr>
                    <th scope="row">2</th>
                    <td>TYPO3</td>
                    <td></td>
                    <td>@typo3</td>
                </tr>
            </tbody>
        </table>
    </div>

    <h2>Table with footer</h2>
    <div class="table-fit">
        <table class="table table-hover">
            <thead>
                <tr>
                    <th scope="col">#</th>
                    <th scope="col">First</th>
                    <th scope="col">Last</th>
                    <th scope="col">Handle</th>
                </tr>
            </thead>
            <tbody>
                <tr>
                    <th scope="row">1</th>
                    <td>Benjamin</td>
                    <td>Kott</td>
                    <td>@benjaminkott</td>
                </tr>
                <tr>
                    <th scope="row">2</th>
                    <td>TYPO3</td>
                    <td></td>
                    <td>@typo3</td>
                </tr>
            </tbody>
            <tfoot>
                <tr>
                    <th colspan="4">FOOTER</th>
                </tr>
            </tfoot>
        </table>
    </div>

    <h2>Table with footer and caption</h2>
    <div class="table-fit">
        <table class="table table-hover">
            <caption>List of users</caption>
            <thead>
                <tr>
                    <th scope="col">#</th>
                    <th scope="col">First</th>
                    <th scope="col">Last</th>
                    <th scope="col">Handle</th>
                </tr>
            </thead>
            <tbody>
                <tr>
                    <th scope="row">1</th>
                    <td>Benjamin</td>
                    <td>Kott</td>
                    <td>@benjaminkott</td>
                </tr>
                <tr>
                    <th scope="row">2</th>
                    <td>TYPO3</td>
                    <td></td>
                    <td>@typo3</td>
                </tr>
            </tbody>
            <tfoot>
                <tr>
                    <th colspan="4">FOOTER</th>
                </tr>
            </tfoot>
        </table>
    </div>
</div>

<hr>

<div class="p-5">
    <h2>Table bordered</h2>
    <div class="table-fit">
        <table class="table table-bordered table-hover">
            <thead>
                <tr>
                    <th scope="col">#</th>
                    <th scope="col">First</th>
                    <th scope="col">Last</th>
                    <th scope="col">Handle</th>
                </tr>
            </thead>
            <tbody>
                <tr>
                    <th scope="row">1</th>
                    <td>Benjamin</td>
                    <td>Kott</td>
                    <td>@benjaminkott</td>
                </tr>
                <tr>
                    <th scope="row">2</th>
                    <td>TYPO3</td>
                    <td></td>
                    <td>@typo3</td>
                </tr>
            </tbody>
        </table>
    </div>

    <h2>Table bordered with caption</h2>
    <div class="table-fit">
        <table class="table table-bordered table-hover">
            <caption>List of users</caption>
            <thead>
                <tr>
                    <th scope="col">#</th>
                    <th scope="col">First</th>
                    <th scope="col">Last</th>
                    <th scope="col">Handle</th>
                </tr>
            </thead>
            <tbody>
                <tr>
                    <th scope="row">1</th>
                    <td>Benjamin</td>
                    <td>Kott</td>
                    <td>@benjaminkott</td>
                </tr>
                <tr>
                    <th scope="row">2</th>
                    <td>TYPO3</td>
                    <td></td>
                    <td>@typo3</td>
                </tr>
            </tbody>
        </table>
    </div>

    <h2>Table bordered with caption top</h2>
    <div class="table-fit">
        <table class="table table-bordered table-hover caption-top">
            <caption>List of users</caption>
            <thead>
                <tr>
                    <th scope="col">#</th>
                    <th scope="col">First</th>
                    <th scope="col">Last</th>
                    <th scope="col">Handle</th>
                </tr>
            </thead>
            <tbody>
                <tr>
                    <th scope="row">1</th>
                    <td>Benjamin</td>
                    <td>Kott</td>
                    <td>@benjaminkott</td>
                </tr>
                <tr>
                    <th scope="row">2</th>
                    <td>TYPO3</td>
                    <td></td>
                    <td>@typo3</td>
                </tr>
            </tbody>
        </table>
    </div>

    <h2>Table bordered with footer</h2>
    <div class="table-fit">
        <table class="table table-bordered table-hover">
            <thead>
                <tr>
                    <th scope="col">#</th>
                    <th scope="col">First</th>
                    <th scope="col">Last</th>
                    <th scope="col">Handle</th>
                </tr>
            </thead>
            <tbody>
                <tr>
                    <th scope="row">1</th>
                    <td>Benjamin</td>
                    <td>Kott</td>
                    <td>@benjaminkott</td>
                </tr>
                <tr>
                    <th scope="row">2</th>
                    <td>TYPO3</td>
                    <td></td>
                    <td>@typo3</td>
                </tr>
            </tbody>
            <tfoot>
                <tr>
                    <th colspan="4">FOOTER</th>
                </tr>
            </tfoot>
        </table>
    </div>

    <h2>Table bordered with footer and caption</h2>
    <div class="table-fit">
        <table class="table table-bordered table-hover">
            <caption>List of users</caption>
            <thead>
                <tr>
                    <th scope="col">#</th>
                    <th scope="col">First</th>
                    <th scope="col">Last</th>
                    <th scope="col">Handle</th>
                </tr>
            </thead>
            <tbody>
                <tr>
                    <th scope="row">1</th>
                    <td>Benjamin</td>
                    <td>Kott</td>
                    <td>@benjaminkott</td>
                </tr>
                <tr>
                    <th scope="row">2</th>
                    <td>TYPO3</td>
                    <td></td>
                    <td>@typo3</td>
                </tr>
            </tbody>
            <tfoot>
                <tr>
                    <th colspan="4">FOOTER</th>
                </tr>
            </tfoot>
        </table>
    </div>
</div>
Actions
Copy link
 #9

Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78543

Actions
Copy link
 #10

Updated by Benjamin Kott over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #11

Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF