Project

General

Profile

Actions

Bug #102138

open

XLF files not working for finishers

Added by Jakub Zgirski 7 months ago. Updated 3 months ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2023-10-10
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
12
PHP Version:
8.2
Tags:
form, finisher, translation
Complexity:
Is Regression:
Sprint Focus:

Description

We have a website that has the default DE language. We configure EXT:form, add the locallang.xlf and de.locallang.xlf files with translations for the finisher.
In my test i used EmailToReceiverFinisher and ConfirmationFinisher. For some reason both finishers use english translations (locallang.xlf) and when i remove EmailToReceiverFinisher from form definition then ConfirmationFinisher works like expected - it shows message from de.locallang.xlf.

Actions #1

Updated by Michael Reuber 6 months ago

  • PHP Version changed from 8.1 to 8.2

Jakub Zgirski wrote:

We have a website that has the default DE language. We configure EXT:form, add the locallang.xlf and de.locallang.xlf files with translations for the finisher.
In my test i used EmailToReceiverFinisher and ConfirmationFinisher. For some reason both finishers use english translations (locallang.xlf) and when i remove EmailToReceiverFinisher from form definition then ConfirmationFinisher works like expected - it shows message from de.locallang.xlf.

I can confirm this behavior

Actions #2

Updated by Nikita Hovratov 6 months ago

The documentation states that default behaviour should be the request language: https://docs.typo3.org/c/typo3/cms-form/main/en-us/I/Config/proto/finishersDefinition/finishers/EmailToReceiver.html#options-translation-language

A security patch changed the default value to the "default language": https://review.typo3.org/c/Packages/TYPO3.CMS/+/68436

I think this might be the issue, why finisher translations started to have the default translation language (english) in every language.

Removing the entry:

      translation:
        language: Default

restores the automatic behaviour. This is only possible through manual editing of the YAML though. I believe the select field needs another entry for "Auto".

Actions #3

Updated by Gerrit Code Review 6 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81583

Actions #4

Updated by Gerrit Code Review 6 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81583

Actions #5

Updated by Gerrit Code Review 6 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81583

Actions #6

Updated by Gerrit Code Review 5 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81583

Actions #7

Updated by Gerrit Code Review 5 months ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81583

Actions #8

Updated by Gerrit Code Review 3 months ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81583

Actions

Also available in: Atom PDF