Bug #102612: Calling ExpressionBuilder::in and notIn with empty array or string causes SQL Error - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #102612

closed

Calling ExpressionBuilder::in and notIn with empty array or string causes SQL Error

Added by Lina Wolf 12 months ago. Updated 5 months ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Database API (Doctrine DBAL)

Target version:

Start date:

2023-12-06

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

I would suggest to test for invalid data here - same as we do with inSet

Actions

Copy link

Updated by Lina Wolf 12 months ago

Current Exception is:

Doctrine\DBAL\Exception\SyntaxErrorException prototype object
   message => protected "An exception occurred while executing 'UPDATE `tt_content` SET `CType` = ? W
      HERE `uid` IN ()' with params ["xyz"]:

You have an err
      or in your SQL syntax; check the manual that corresponds to your MariaDB ser
      ver version for the right syntax to use near ')' at line 1" (286 chars)

There is no unit test for this case

Actions

Copy link

Updated by Gerrit Code Review 12 months ago

Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82132

Actions

Copy link

Updated by Gerrit Code Review 12 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82132

Actions

Copy link