Bug #102890
closed
array_reverse rootline for PageLayoutResolver::getLayoutForPage calls
0%
Description
The given rootline is not reversed, therefore conditions like tree.pagelayout don't work.
Updated by Gerrit Code Review 3 months ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82560
Updated by Gerrit Code Review 3 months ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82560
Updated by Gerrit Code Review 3 months ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82560
Updated by Nikita Hovratov 3 months ago
Can you give please an actual example which condition apparently doesn't work? Context: We have already fixed this pesky area 1 or 2 times and I'm pretty confident it works correctly.
Updated by Dimitri König 3 months ago
· Edited
[tree.pagelayout == "something"] does not work as it should in FE. It works in BE, and as you can see from the 12.4 code, the backend pagelayout code is called with a reversed rootline.
If you look at the tests (before my patch) they already have an inversed array given to the resolver, therefore this issue did not come up.
I'm now using composer patches in a fresh 12.4 installation with this patch active, and now everything works as it should. But it would be nice to have that fixed in the core.
Updated by Nikita Hovratov 3 months ago
- Related to Bug #100764: TS condition does not work added
Updated by Nikita Hovratov 3 months ago
- Related to Bug #102268: TypoScript conditions for tree.pagelayout do not work correctly on page level 1 added
Updated by Nikita Hovratov 3 months ago
Thanks for the feedback. We will investigate. This is probably more complex than simply array_reverse. We need to setup proper Frontend Tests for that so we do not create another regression. This condition caused a lot of headaches already.
Updated by Nikita Hovratov 3 months ago
- Related to Task #100047: Modernize condition matching / expression handling added
Updated by Nikita Hovratov 3 months ago
- Related to deleted (Bug #102268: TypoScript conditions for tree.pagelayout do not work correctly on page level 1)
Updated by Nikita Hovratov 3 months ago
- Is duplicate of Bug #102268: TypoScript conditions for tree.pagelayout do not work correctly on page level 1 added
Updated by Nikita Hovratov 3 months ago
- Status changed from Under Review to Closed
@Dimitri König I've investigated the issue and can confirm this is a bug. I've found an older ticket for the same issue: #102268. So I will close this ticket in favor of it.