Project

General

Profile

Actions

Task #103926

closed

Avoid implicitly nullable parameter on DatabaseRecordException

Added by Stefan Bürk 22 days ago. Updated 21 days ago.

Status:
Resolved
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2024-05-26
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

With PHP 8.4 marking method parameter implicitly nullable
is depreacted and will emit a `E_DEPRECATED` warning. One
recommended way to resolve this, is making it explicitly
nullable using the `?` nullable operator. [1]

In cases, where are implicitly nullable parameter exists
before not-nullable parameters in a method or constructor,
making it explicitly nullable will emit a

Optional parameter <paramname> declared before required
parameter <paramname> is implicitly treated as a required
parameter

since PHP 8.0 [2].

This change modifies the class constructor signature of
`\TYPO3\CMS\Backend\Form\Exception\DatabaseRecordException`
and moves the required parameter before the optional and
nullable previous execption parameter and adjust the
core place throwing this exception to follow that pattern.

[1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated
[2] https://php.watch/versions/8.0/deprecate-required-param-after-optional

Actions #1

Updated by Stefan Bürk 22 days ago

  • Tracker changed from Bug to Task
Actions #2

Updated by Gerrit Code Review 22 days ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84415

Actions #3

Updated by Gerrit Code Review 22 days ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84415

Actions #4

Updated by Gerrit Code Review 21 days ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84415

Actions #5

Updated by Gerrit Code Review 21 days ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84415

Actions #6

Updated by Gerrit Code Review 21 days ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84360

Actions #7

Updated by Gerrit Code Review 21 days ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84361

Actions #8

Updated by Stefan Bürk 21 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF