Project

General

Profile

Actions

Task #103962

closed

suppress another phpstan error

Added by Anja Leichsenring about 1 month ago. Updated 6 days ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2024-06-01
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
13
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

with #99146 GeneralUtility::makeInstance received a parameter clarification for phpstan. This parameter (in effect being a string) is used to compare against it being empty. But phpstan itself insists on this comparison being always false due to the annotation, which in reality is not true.
So the error is just suppressed, along with the rest introduced with the annotation change.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #99146: Improve the type annotations around GU::makeInstance & friendsClosedOliver Klee2022-11-20

Actions
Actions #1

Updated by Anja Leichsenring about 1 month ago

  • Related to Task #99146: Improve the type annotations around GU::makeInstance & friends added
Actions #2

Updated by Gerrit Code Review about 1 month ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84472

Actions #3

Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84472

Actions #4

Updated by Gerrit Code Review about 1 month ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84473

Actions #5

Updated by Gerrit Code Review about 1 month ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84472

Actions #6

Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84473

Actions #7

Updated by Anja Leichsenring about 1 month ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack 6 days ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF