Task #103962
closed
suppress another phpstan error
100%
Description
with #99146 GeneralUtility::makeInstance received a parameter clarification for phpstan. This parameter (in effect being a string) is used to compare against it being empty. But phpstan itself insists on this comparison being always false due to the annotation, which in reality is not true.
So the error is just suppressed, along with the rest introduced with the annotation change.
Updated by Anja Leichsenring 6 months ago
- Related to Task #99146: Improve the type annotations around GU::makeInstance & friends added
Updated by Gerrit Code Review 6 months ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84472
Updated by Gerrit Code Review 6 months ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84472
Updated by Gerrit Code Review 6 months ago
Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84473
Updated by Gerrit Code Review 6 months ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84472
Updated by Gerrit Code Review 6 months ago
Patch set 2 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84473
Updated by Anja Leichsenring 6 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 7cfec77f35823ad4ca08df93955ea7cf1a239572.
Updated by