Project

General

Profile

Actions

Task #104174

closed

Reduce GU::makeInstance usage in functional tests

Added by Anja Leichsenring 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Category:
Tests
Target version:
-
Start date:
2024-06-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
13
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Additional potential functionality (XClass resolving, etc.) of
GU::makeInstance is usually not a wanted behaviour in functional tests.
Instead, use $this->get() from the FunctionalTestClass to get hold of services.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #103902: Reduce GU::makeInstance usage in unit testsClosedAnja Leichsenring2024-05-24

Actions
Actions #1

Updated by Anja Leichsenring 5 months ago

  • Related to Task #103902: Reduce GU::makeInstance usage in unit tests added
Actions #2

Updated by Gerrit Code Review 5 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84818

Actions #3

Updated by Gerrit Code Review 5 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84818

Actions #4

Updated by Gerrit Code Review 5 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84818

Actions #5

Updated by Gerrit Code Review 5 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84818

Actions #6

Updated by Anja Leichsenring 5 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF