Bug #105152: 503 when editor has no access to the default storage #2 - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #105152

closed

503 when editor has no access to the default storage #2

Added by Wolfgang Klinger 9 months ago. Updated 4 months ago.

Status:

Resolved

Priority:

Must have

Assignee:

Category:

Backend API

Target version:

Start date:

2024-09-27

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

trivial

Is Regression:

Sprint Focus:

Description

The bug (tried) to fix here: https://forge.typo3.org/issues/103897
is still an open bug here: typo3/cms-filelist/Classes/LinkHandler/AbstractResourceLinkHandler.php:198
where the same condition is used.

        if (!$this->selectedFolder) {
            $this->selectedFolder = $this->resourceFactory->getDefaultStorage()?->getRootLevelFolder() ?? null;
        }

How to reproduce:
- Create a text element
- Add some text
- Link the text
- Select "File" in the opening dialog
- Booomm

Solution is the same as in the already published fix:

        if (!$this->selectedFolder) {
            $allStorages = $this->getBackendUser()->getFileStorages();
            $defaultStorage = $this->resourceFactory->getDefaultStorage();
            if ($defaultStorage && array_key_exists($defaultStorage->getUid(), $allStorages)) {
                $this->selectedFolder = $defaultStorage->getRootLevelFolder();
            } else {
                $this->selectedFolder = reset($allStorages)->getRootLevelFolder();
            }
        }

Related issues 3 (0 open — 3 closed)

Actions

Copy link

Updated by Wolfgang Klinger 9 months ago

Related to Bug #103897: Reproducable 503 when editor has no access to the default storage added

Actions

Copy link

Updated by Dennis Grün 7 months ago

Can confirm, editors without access to default storage opening link browser in file mode just throws exception 1375955684.

Actions

Copy link

Updated by Tobias Wollender 5 months ago

We also had this problem today (with TYPO3 12.4.24). Thanks for the proposed fix, which worked as described.

Actions

Copy link

Updated by Gerrit Code Review 5 months ago

Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87872

Actions

Copy link

Updated by Gerrit Code Review 5 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87872

Actions

Copy link

Updated by Gerrit Code Review 5 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87872

Actions

Copy link

Updated by Gerrit Code Review 5 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87872

Actions

Copy link

Updated by Gerrit Code Review 5 months ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87872

Actions

Copy link

Updated by Gerrit Code Review 5 months ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87872

Actions

Copy link

#10

Updated by Gerrit Code Review 5 months ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87872

Actions

Copy link

#11

Updated by Christian Kuhn 5 months ago

Related to Bug #106038: Avoid exception in file element browser added

Actions

Copy link

#12

Updated by Gerrit Code Review 5 months ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87872

Actions

Copy link

#13

Updated by Gerrit Code Review 5 months ago

Patch set 1 for branch 13.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87956

Actions

Copy link

#14

Updated by Gerrit Code Review 5 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87957

Actions

Copy link

#15