Project

General

Profile

Actions

Bug #105541

closed

TYPO3 13.4: calling getSysTemplateRowsByRootline with empty array as $rootline causes sql error

Added by Lina Wolf 16 days ago. Updated 14 days ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
TypoScript
Target version:
-
Start date:
2024-11-05
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
13
PHP Version:
8.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If $rootline is empty, then a SQL like the following is produced by the query builder:

```
SELECT sys_template.* FROM sys_template INNER JOIN (SELECT ) pidlist ON (sys_template.pid = pidlist.uid)
```

The method is for exmample called by solr with an empty $rootline array if there are not typoscript records. This blows up the whole scheduler backend module even for unrelated scheduler tasks, see also https://github.com/TYPO3-Solr/ext-solr/issues/4208

If the $rootline array is empty it should be safe to return [] in this method.

If we do not want the method to be called at all with an empty array we should throw an exception.


Files

empty_rootline.patch (856 Bytes) empty_rootline.patch Lina Wolf, 2024-11-05 08:29
Actions #1

Updated by Lina Wolf 16 days ago

This patch solves it for me

Actions #2

Updated by Gerrit Code Review 16 days ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86887

Actions #3

Updated by Gerrit Code Review 16 days ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86887

Actions #4

Updated by Gerrit Code Review 14 days ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86902

Actions #5

Updated by Gerrit Code Review 14 days ago

Patch set 1 for branch 13.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86903

Actions #6

Updated by Georg Ringer 14 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF