Bug #14360
closed
Fatal error at 3: Image Processing -> 5: GD library functions
0%
Description
To reproduce log on to the Install Tool and select "4: All Configuration".
Search for "[forceCharset]".
Enter any valid charset, apart from UTF-8.
Save the new settings.
Select "3: Image Processing" and then "5: GD library functions".
The Install Tool will crash, issuing a fatal error.
The stack trace below leads to the assumption that the error happens in the file "t3lib/class.t3lib_stdgraphic.php". Most likely at line 288.
[15-Oct-2004 18:35:34] PHP Stack trace:
[15-Oct-2004 18:35:34] PHP 1. {main}() /home/www/typo3_src-3.7.0/typo3/install/index.php:0
[15-Oct-2004 18:35:34] PHP 2. require() /home/www/typo3_src-3.7.0/typo3/install/index.php:58
[15-Oct-2004 18:35:34] PHP 3. tx_install->init() /home/www/typo3_src-3.7.0/typo3/init.php:218
[15-Oct-2004 18:35:34] PHP 4. tx_install->checktheimageprocessing() /home/www/typo3_src-3.7.0/typo3/sysext/install/mod/class.tx_install.php:388
[15-Oct-2004 18:35:34] PHP 5. t3lib_stdgraphic->calcbbox() /home/www/typo3_src-3.7.0/typo3/sysext/install/mod/class.tx_install.php:2835
[15-Oct-2004 18:35:34] PHP 6. t3lib_stdgraphic->recodestring() /home/www/typo3_src-3.7.0/t3lib/class.t3lib_stdgraphic.php:718
[15-Oct-2004 18:35:34] PHP Fatal error: Call to a member function on a non-object in /home/www/typo3_src-3.7.0/t3lib/class.t3lib_stdgraphic.php on line 1886
(issue imported from #M422)
Files
Updated by Michael Stucki about 19 years ago
Well, obviously the $LANG object is not initiated by the Install Tool as my patch now does. In short, this is mostly the same as at the end of typo3/template.php.
Some notes about that:
To me it seems this is only needed when "3: Image Processing", "5: GD library functions" is opened. Since the class needs some memory (don't know how much) it would probably be wise to fire up the class only then.
On the other hand, it's probably cleaner to load it always when the Install Tool is started because then it would also work in any other situation.
Question: What's the better option?
Updated by Andreas Otto † about 19 years ago
The cleaner solution might be the right thing to do. If it turns out to require too much memory we can still go for the faster but less clean solution.
Updated by Michael Stucki about 19 years ago
This is Kaspers reply to my question:
The only reason for using LANG is (AFAIR) that we want to convert charsets, right? So, in line 288 where ->csConvObj is set, simply check if global $LANG is available and if not, create the csConvObj as a pure instance of t3lib_cs - that is all it is!
Makes sense, so I've changed it this way and submitted this to CVS.