Project

General

Profile

Actions

Feature #14428

closed

The "Access Key" combination is not added to the "title" Attribute

Added by Wolfgang Klinger almost 20 years ago. Updated over 18 years ago.

Status:
Closed
Priority:
Should have
Category:
Frontend
Target version:
-
Start date:
2004-12-01
Due date:
% Done:

0%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The "Access Key" combination is added to the "alt" Attribute of the image (Title [ALT+A]) but not to the "title" Attribute of the link (GMENU).
I would like to see it in both or at least have the option to have it added there. tia!

see attached patch
(issue imported from #M569)


Files

0000569-tslib_menu.diff (1.47 KB) 0000569-tslib_menu.diff Administrator Admin, 2004-12-01 15:15
bug_0569.patch (1.67 KB) bug_0569.patch Administrator Admin, 2005-11-11 18:21
Actions #1

Updated by Sacha Vorbeck about 19 years ago

keyword:accessibility

Actions #2

Updated by Sebastian Kurfuerst about 19 years ago

the new patch is only an update from the old one based on CVS sources.
Greets, Sebastian

Actions #3

Updated by Sebastian Kurfuerst about 19 years ago

concerning the following line:
$titleAttrValue = $this->WMcObj->stdWrap($this->I['val']['ATagTitle'],$this->I['val']['ATagTitle.']).$this->I['accessKey']['alt'];
should this maybe rather be
$titleAttrValue = $this->WMcObj->stdWrap($this->I['val']['ATagTitle'].$this->I['accessKey']['alt'],$this->I['val']['ATagTitle.']);

I don't know... Some other opinions?
Greets, Sebastian

Actions #4

Updated by Ernesto Baschny about 19 years ago

I think that is not correct, Sebastian. As already noted on ICQ:

Someone might want to get the ATagTitle completely via stdWrap (e.g via .data) and this would replace the content, but he still wants the (ALT-x) appended.

Also I have noted that its pretty ugly to have this hard-coded in the source. For the next release we should think on having this configurable, maybe storing the accessKey in a register and let stdWrap add the {register:accessKey} if desired. This could allow more flexible setups. For that we probably need to pass imgParams through stdWrap too.

Actions #5

Updated by Sebastian Kurfuerst about 19 years ago

fixed in CVS.

Actions

Also available in: Atom PDF