Project

General

Profile

Actions

Bug #14919

closed

t3lib_div::array_merge_recursive_overlay cannot overrule arrays with scalars

Added by Jens Scheidtmann almost 19 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2005-08-11
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
3.8
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

if t3lib_div::array_merge_recursive_overlay is called with an array which contains arrays, the subarrays cannot be overruled by scalar values in the second array, as no code exists for the case that $arr0[$key] is an array, but $arr1[$key] is not.

This is unfortunate as pi_linkTP_keepPiVars(_url) documentation says for its $overrulePIvars parameter: "Further, if a value is a blank string it means the piVar key will not be a part of the link (unset)". As this function uses array_merge_recursive_overlay, one cannot unset a form.

I have included a patch, I hope it is useful despite of my smattering of php arrays . . .

(issue imported from #M1367)


Files

t3lib_div.patch (781 Bytes) t3lib_div.patch Administrator Admin, 2005-08-11 16:18
t3lib_div.good.patch (611 Bytes) t3lib_div.good.patch Administrator Admin, 2005-08-11 16:29
Actions #1

Updated by Jens Scheidtmann almost 19 years ago

[...] one cannot unset a form.

I meant for sure:

... one cannot unset a subarray of piVars,

Actions #2

Updated by Jens Scheidtmann almost 19 years ago

First patch is defective. Uploaded working one. Could please somebody delete t3lib_div.patch? I get Access Denied.

Actions #3

Updated by Alexander Opitz almost 11 years ago

  • Status changed from Accepted to Needs Feedback
  • Target version deleted (0)
  • TYPO3 Version changed from 3.8.0 to 3.8
  • PHP Version deleted (4)

Hi,

as this issue is very old. Does the problem still exists within newer versions of TYPO3 CMS (4.5 or 6.1)?

Actions #4

Updated by Alexander Opitz over 10 years ago

  • Status changed from Needs Feedback to Closed
  • Assignee deleted (Rupert Germann)
  • Is Regression set to No

No feedback within the last 90 days => closing this ticket.

If you think that this is the wrong decision or experience this issue again, then please write to the mailing list typo3.teams.bugs with issue number and an explanation or open a new ticket and add a relation to this ticket number.

Actions

Also available in: Atom PDF