TYPO3 Core

Hi,
the current patch bug_1369_2.patch is the revised version by Ernesto and me. Comments are welcome!
Greets, Sebastian

Some comments I got:

So I start with a small observation on cleanFormName. It uses an ereg_replace and we've agreed to use preg_replace. And it does a trim twice (the second is superfluos).
Is the substr really necessary? Shortened ids are probably more annoying the long ids. I recall no lenght limit from the standards.

So back to the main FORM function.
The description says in xhtml strict mode name is replaced with id in the form tag. From the patch it looks like it is always changed.

Greets, Sebastian

Sebastian, the cleanFormName() is not really mine, but let's see:

1) the correct syntax is "preg_replace('/\[|\]\[?/',':',trim($name));", so just add "/" around the query works. The expression substitutes: "[" OR "] followed or not by another [" with ":", so "data[x][y]" gets "data:x:y:", as documented

2) the second trim() is superfluous, you can get rid of it.

3) I'm not sure about the limitation to 30 chars, maybe the original author (Rupi?) can give us info about it?

4) Even in HTML 4.01 the "name" attribute in the FORM is deprecated (see http://www.w3.org/TR/REC-html40/interact/forms.html#h-17.3): "name (...) Note. This attribute has been included for backwards compatibility. Applications should use the id attribute to identify elements."

So this is what we do in the JavaScript: we use document.getElementById(), which is DOM Level 1, W3C standard, supported by all major browsers since 1999 (IE>5). It won't probably work on NN4, and I'm not sure if "document.formname" which we have as a fallback works on IE4. I have no way to test it.

Hi, I've uploaded a new patch.
1 - done. Thanks
.2. Yes, did it.
3. There is no limitation in the standards, I removed it.

Greets, Sebastian

The description says in xhtml strict mode name is replaced with id
inthe form tag. From the patch it looks like it is always changed.

Yes, but this doesn't break backwards-compatibility, does it?

It may well be that it does. Why break some stupid browsers, just because of this xhtml crave? <rant>I really like standards, but I begin to hate XHTML 1.1. What has been gained by removing the name attribute?</rant>

I see no point in breaking the page for some users when we can fix it by using id only for "progressive" xhtml versions. If I stick to old html standards I expect that TYPO3 delivers "old" code.

=> Concering the last point... is there a unified method to check for XHTML? just an
if ($this->conf['doctype'] = 'xhtml')?

I'll try to verify this, this note is as well a personal reminder for me
Greets, Sebastian

Ok, Sebastian, so I suggest change the patch. From:

- ' name="'.$formname.'"'.
+ ' id="'.$formname.'"'.

to:

- ' name="'.$formname.'"'.
+ ' id="'.$formname.'"'.($xhtmlStrict ? '' : ' name="'.$formname.'"').

This will make the forms that are not XHTML 1.1 strict also work on Netscape 4.

As of "unified method to check for XHTML?" I don't understand what you mean. There are several "flavours" of XHTML.

xhtml = XHTML 1.0 Transitional
xhtml_strict = XHTML 1.0 Strict
xhtml_11 = XHTML 1.1
xhtml_2 = future... XHTML 2.0?

The last 3 are "strict" variants, while the first allows almost everything that was allowed in HTML 4.01 (with XML-syntax, of course).

Thus, $xhtmlStrict (used in my patch) is currently being created in the FORM code directly:

$xhtmlStrict = t3lib_div::inList('xhtml_strict,xhtml_11,xhtml_2',$GLOBALS['TSFE']->config['config']['doctype']);

Maybe this could be moved to some init-method ("start()"?) and set to $this->xhtmlStrict so that other cObject methods can make use of it?

Cheers,
Ernesto

Hi Ernesto,
thanks for your input! It is highly appreciated as I can work faster then. A revised version is at the core list right now.

Greets, Sebastian

fixed in CVS. It would be great if you could test it again to make sure everything works as expected. I had to merge parts of the patch by hand.

Thanks and greets, Sebastian