Project

General

Profile

Actions

Bug #14992

closed

Header with link wraps not proper

Added by Anonymous about 19 years ago. Updated almost 14 years ago.

Status:
Closed
Priority:
Should have
Category:
Frontend
Target version:
-
Start date:
2005-09-24
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
3.8.0
PHP Version:
4
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

HTML - output if you make a headline with link:

<a href="index.php?id=352"><h1>Lorem ipsum dolor</h1></a>

It you additionally check date, the output is the following:
<a href="index.php?id=352">
<div class="c_date">25. Sep, 2005</div>
<h1>Das Strahlenfrühwarnsystem im Wandel der Zeit Lorum Ipsum dolor ist amet</h1>
</a>

It should be:
<h1><a href="index.php?id=352">Lorem ipsum dolor</a></h1>

and with date:
<div class="c_date">25. Sep, 2005</div>
<a href="index.php?id=352"><h1><a href="index.php?id=352">Lorem ipsum dolor</a></h1></a>

for passing the w3 validator
(issue imported from #M1482)


Files

2005-10-18_bugfix_1482.patch (94.5 KB) 2005-10-18_bugfix_1482.patch Administrator Admin, 2005-10-18 11:01
Actions #1

Updated by Dmitry Pikhno about 19 years ago

overwrite default typoscript with following

lib.stdheader.stdWrap.typolink >
lib.stdheader.10.1.typolink.parameter.field = header_link # header1
lib.stdheader.10.2.typolink.parameter.field = header_link # header2
.......
lib.stdheader.10.N.typolink.parameter.field = header_link # headerN

Actions #2

Updated by Sebastian Kurfuerst about 19 years ago

the current diff updates the static template to make it work. You have to re-import static data in the install tool afterwards. Greets, Sebastian

Actions #3

Updated by Anonymous about 19 years ago

update:

lib.stdheader.stdWrap.typolink >

  1. normal text-header:
    lib.stdheader.10.2.fontTag >
    lib.stdheader.10.2.typolink.parameter.field = header_link
    lib.stdheader.10.2.wrap = <h2>|</h2>
  1. graphical header:
    lib.stdheader.10.5.stdWrap.typolink.parameter.field = header_link
    lib.stdheader.10.5.stdWrap.wrap = <h5>|</h5>
Actions #4

Updated by Sebastian Kurfuerst about 19 years ago

Hi,
why did you update your TypoScript? It should not be needed anymore after using the attached patch and re-importing static data in the install tool.
Or maybe I got something wrong?
Greets, Sebastian

Actions #5

Updated by Anonymous about 19 years ago

hi,
because <a></a> is still wrapping outside of <h1></h1> with the patch from dmitry. the <a> tags should be INSIDE the <h1> container. in order to achieve that 'fontTag' must be cleared and <h1> added with wrap.
also stdWrap must be added for graphical headers.
greetings, boris

Actions #6

Updated by Sebastian Kurfuerst about 19 years ago

Hi Boris,
did you test it with my patch or with the example provided by Dmitry? I hope my patch fixes this as well.
Greets, Sebastian

Actions #7

Updated by Sebastian Kurfuerst about 19 years ago

Hi,
did you already have time to test my patch? Greets, Sebastian

Actions #8

Updated by Anonymous about 19 years ago

I tested it with the example provided by Dmitry and patched it, see above!

Actions #9

Updated by Christian Kuhn almost 14 years ago

Resolved, no change required:

This was solved in recent versions, wasn't it? Please reopen if issue still exists.

Actions

Also available in: Atom PDF