Project

General

Profile

Actions

Bug #15291

closed

Remove commented-out code from the EM

Added by Oliver Klee almost 19 years ago. Updated over 18 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2005-12-17
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.0
PHP Version:
4
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

There is lots of commented-out code in mod/tools/em/index.php. This is bad because:

1. it makes the code less readable
2. it increases the file
3. the commented-out code tends to stay there for a very long time as it is not clear when and why the code was commented out

Code that is not needed any more should be deleted. Code that is not ready for check-in should not be checked in to CVS.

I've attached a patch (against the current CVS) that removes that code. I've left one comment untouched - what shall we do with that? I propose removing them as well (or use them):

// New headers suggested by Xin:
// For now they are commented out because a) I have seen no official support yet, b) when clicking the back-link in MSIE after download you see ugly binary stuff and c) I couldn't see a BIG difference, in particular not in Moz/Opera.
/* header('Content-Type: application/force-download');
header('Content-Length: '.strlen($backUpData));
header('Content-Disposition: attachment; filename='.$filename);
header('Content-Description: File Transfer');
header('Content-Transfer-Encoding: binary');
*/

(issue imported from #M2054)


Files

em_remove_garbage.diff (8.33 KB) em_remove_garbage.diff Administrator Admin, 2005-12-17 13:32
Actions #1

Updated by Sebastian Kurfuerst almost 19 years ago

Hi Karsten,
I think you are currently working on the EM, could you care about this?

Thanks,
Sebastian

Actions #2

Updated by Karsten Dambekalns almost 19 years ago

Fixed locally, but not yet in CVS.

Actions #3

Updated by Oliver Klee almost 19 years ago

Please only resolve this bug if this is fixed in CVS - only fixing it in some local tree doesn't actually resolve the problem for the official TYPO3. Thanks. :-)

Actions #4

Updated by Karsten Dambekalns almost 19 years ago

very funny.

Actions

Also available in: Atom PDF