Project

General

Profile

Actions

Bug #15336

closed

Gremlin? changing extended view in list mode changes focus

Added by Stefano Cecere almost 19 years ago. Updated over 18 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2005-12-29
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.0
PHP Version:
4
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

i have many tables in a page.

-> list mode: i see a part of them all.

i select one and just list that table.

now if a change the view mode (from extended view<->normal view) the windows goes back to show ALL the tables.. that is: it doesn't keep the focus on a particular table.

i thing this ugly bug is terrible for editors.

(issue imported from #M2136)


Files

patchfile.patch (2.89 KB) patchfile.patch Administrator Admin, 2005-12-29 22:44
Actions #1

Updated by Stefano Cecere almost 19 years ago

in fact (source code of the check box in the page):

<input type="checkbox" name="SET[bigControlPanel]" onclick="jumpToUrl('db_list.php?&amp;id=476&amp;SET[bigControlPanel]='+(this.checked?1:0),this);" />

it goes back to the page list...

should be simply changed in:

<input type="checkbox" name="SET[bigControlPanel]" onclick="jumpToUrl('db_list.php?id=476&amp;table=name_of_current_table&amp;SET[bigControlPanel]='+(this.checked?1:0),this);" />

that is: add "&table=name_of_current_table" to the jump URL

Actions #2

Updated by Stefano Cecere almost 19 years ago

the code generating this is:

line 383 of db_list.php

$this->content.=t3lib_BEfunc::getFuncCheck($this->id,'SET[bigControlPanel]',$this->MOD_SETTINGS['bigControlPanel'],'db_list.php','').' '.$LANG->getLL('largeControl',1).'<br />';

it should become:

$this->content.=t3lib_BEfunc::getFuncCheck($this->id,'SET[bigControlPanel]',$this->MOD_SETTINGS['bigControlPanel'],'db_list.php','&table=current_table_name').' '.$LANG->getLL('largeControl',1).'<br />';

IF current_table_name <> ''

Actions #3

Updated by Stefano Cecere almost 19 years ago

HERE IS THE PATCH:

change line 383 of db_list.php from:
$this->content.=t3lib_BEfunc::getFuncCheck($this->id,'SET[bigControlPanel]',$this->MOD_SETTINGS['bigControlPanel'],'db_list.php','').' '.$LANG->getLL('largeControl',1).'<HERE IS A BR!!! br />';

TO:

$this->content.=t3lib_BEfunc::getFuncCheck($this->id,'SET[bigControlPanel]',$this->MOD_SETTINGS['bigControlPanel'],'db_list.php',($this->table)?'&table='.$this->table:'').' '.$LANG->getLL('largeControl',1).'<HERE IS A BR!!! br />';

Actions #4

Updated by Sebastian Kurfuerst almost 19 years ago

Hi Stefano, can you supply a patch in unified diff format? that would be of great help!
(diff -u oldfile.php newfile.php > patchfile.patch)
Thx, Sebastian

Actions #5

Updated by Stefano Cecere almost 19 years ago

patch uploaded..

wow this is my 2nd patch to the core gremlins! _

please do you remember also to apply patch of bug 1599 in next 4.0 beta?
thanks!

'night

Actions #6

Updated by Stefano Cecere almost 19 years ago

i think the same fix should be applied to the Clipboard and Localization view checkboxes, so to make all 3 buttons have the same behaviour

Actions #7

Updated by Sebastian Kurfuerst almost 19 years ago

fixed in CVS.

Actions

Also available in: Atom PDF