Project

General

Profile

Actions

Bug #15767

closed

tt_content.menu.20 (TYPO3 4.0beta3): wrong wraps for sitemap/menu elements in accessibility mode

Added by Torsten Schrade over 18 years ago. Updated about 14 years ago.

Status:
Closed
Priority:
Should have
Category:
Content Rendering
Target version:
-
Start date:
2006-03-05
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The new listbased menu/sitemap elements are not wrapped correctly: at some places there are still the <p>|</p> wraps from the "old" mode (see css_styled_content/static/setup.txt from line 1129 onwards).

The following is to be done:

1. Add <li>-Tags with wrapItemAndSub for each ul-based menu/sitemap
2. remove allWrap (<li>, <p> and others) for each ul-based menu/sitemap

See below for the corrections:

tt_content.menu.20 { # "Menu of these pages"
default.wrap = <ul class="csc-menu csc-menu-def">|</ul>
default.1.NO.allWrap >
default.1.NO.wrapItemAndSub = <li>|</li>
default.1.NO.ATagTitle.field = description // title

  1. "Menu of subpages to these pages"
    1.wrap = <ul class="csc-menu csc-menu-1">|</ul>
    1.1.NO.allWrap >
    1.1.NO.wrapItemAndSub = <li>|</li>
  1. "Sitemap - liststyle"
    2 >
    2 = HMENU
    2 {
    wrap = <div class="csc-sitemap">|</div>
    1 = TMENU
    1 {
    noBlur=1
    expAll=1
    wrap = <ul>|</ul>
    NO {
    stdWrap.htmlSpecialChars = 1
    wrapItemAndSub = <li>|</li>
    ATagTitle.field = description // title
    }
    }
    2<.1
    3<.1
    4<.1
    5<.1
    6<.1
    7<.1
    }
  1. "Section index (pagecontent w/Index checked - liststyle)"
    3.wrap = <ul class="csc-menu csc-menu-3">|</ul>
    3.renderObj.noBlur = 1
    3.renderObj.wrap = <li class="csc-section">|</li>
  1. "Menu of subpages to these pages (with abstract)"
    4.wrap = <dl class="csc-menu csc-menu-4">|</dl>
    4.1.NO {
    allWrap = <dt>|</dd>
    after.wrap = </dt><dd>|
    ATagTitle.field = description // title
    }
  1. "Recently updated pages"
    5.wrap = <ul class="csc-menu csc-menu-5">|</ul>
    5.1.NO.allWrap >
    5.1.NO.wrapItemAndSub = <li>|</li>
  1. "Related pages (based on keywords)"
    6.wrap = <ul class="csc-menu csc-menu-6">|</ul>
    6.1.NO.allWrap >
    6.1.NO.wrapItemAndSub = <li>|</li>
  1. "Menu of subpages to these pages + sections - liststyle"
    7.wrap = <ul class="csc-menu csc-menu-7">|</ul>
    7.1.NO.allWrap >
    7.1.NO.wrapItemAndSub = <li>|</li>
    7.2.wrap = <ul class="csc-section">|</ul>
    7.2.NO.allWrap >
    7.2.NO.wrapItemAndSub = <li>|</li>
    7.2.NO.ATagTitle.field = description // title
    }
    (issue imported from #M2767)

Files

tt_content.menu.20.txt (1.69 KB) tt_content.menu.20.txt Administrator Admin, 2006-03-05 18:04
css_styled_content.setup.diff (3.5 KB) css_styled_content.setup.diff Administrator Admin, 2006-03-13 12:46
bug_2767.patch (1.47 KB) bug_2767.patch Administrator Admin, 2006-03-14 21:15
Actions #1

Updated by Torsten Schrade over 18 years ago

Ooops. I'm very sorry, but the TypoScript above is broken due to the bugtracker eating the HTML in the wraps... I have attached a .txt with the corrections.

Actions #2

Updated by Michael Stucki over 18 years ago

Please tell me exactly what needs to be changed.

Actions #3

Updated by Torsten Schrade over 18 years ago

Hello Michael,

I've made a diff for you - hope this works. Otherwise plz let me know...

Additionally, here's a page that shows the output with the changes to tt_content.menu.20: http://stdwarp.org/index.php?id=177

Actions #4

Updated by Sebastian Kurfuerst over 18 years ago

Hi,
I'll take care of this!

Greets, Sebastian

Actions #5

Updated by Sebastian Kurfuerst over 18 years ago

Hi, I have attached a new patch bug_2767.patch - which greatly reduces the size of it, but there are no functional changes.
I will send this to the core list.
Greets, Sebastian

Actions #6

Updated by JoH over 18 years ago

Seems to be working as expected now.
But there is one part that still doesn't seem to be correct:

+ # "Menu of subpages to these pages (with abstract)"
+ 4.wrap = <dl class="csc-menu csc-menu-4">|</dl>
+ 4.1.NO {
+ allWrap = <dt>|</dd>
+ after.wrap = </dt><dd>|
+ ATagTitle.field = description // title
+ }

In the original setup for this Menutype you get the following setup:

  1. "Menu of subpages to these pages"
    4= HMENU
    4.wrap = <div class="csc-menu csc-menu-4">|</div>
    4 {
    special = directory
    special.value.field = pages
    1 = TMENU
    1.NO {
    allWrap = <p>|</p>
    stdWrap.htmlSpecialChars = 1
    target = {$content.pageFrameObj}
    after.required = 1
    after.data = field : abstract // field : description // field :
    subtitle
    after.htmlSpecialChars = 1
    after.wrap = </p><p class="csc-abstract">|
    }
    }

For cases without any abstract this will produce:

<div class="csc-menu csc-menu-4">
<p>Linked text</p>
</div>

and with abstract it will be:

<div class="csc-menu csc-menu-4">
<p>Linked text</p>
<p class="csc-abstract">Abstract text</p>
</div>

which is valid XHTML.

  1. "Menu of subpages to these pages accessible version"
    4 = HMENU
    4.wrap = <dl class="csc-menu csc-menu-4">|</dl>
    4 {
    special = directory
    special.value.field = pages
    1 = TMENU
    1.NO {
    allWrap = <dt>|</dd>
    after.required = 1
    after.data = field : abstract // field : description // field :
    subtitle
    after.htmlSpecialChars = 1
    after.wrap = </dt><dd>|
    stdWrap.htmlSpecialChars = 1
    target = {$content.pageFrameObj}
    ATagTitle.field = description // title
    }
    }

Here you will get the following results:

With abstract:

<dl class="csc-menu csc-menu-4">
<dt>Linked text</dt>
<dd> Abstract text</dd>
</dl>

Which is still OK but without abstract you will get

<dl class="csc-menu csc-menu-4">
<dt>Linked text</dd>
</dl>

Which is invalid in any version of HTML.

Solution:

+ # "Menu of subpages to these pages (with abstract)"
+ 4.wrap = <dl class="csc-menu csc-menu-4">|</dl>
+ 4.1.NO {
+ allWrap >
+ linkWrap = <dt>|</dt>
+ after.wrap = <dd>|</dd>
+ ATagTitle.field = description // title
+ }

If you change this +1 from me for the rest.

Actions #7

Updated by Sebastian Kurfuerst over 18 years ago

Thanks for all your feedback! I fixed everything in cvs now.
Greets, Sebastian

Actions

Also available in: Atom PDF