Project

General

Profile

Actions

Bug #15829

closed

Highlight un list tree doesn't work on Internet Explorer

Added by GUERARD Vincent over 18 years ago. Updated over 18 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2006-03-15
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.0
PHP Version:
5
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

On RC1 version, the hilight_row function change and use setAttribute to change class attribut field.

For IE, we must user "className" for the first arg, not "class"

On typo3/alt_db_navframe.php, line 278, replace old with new code :

/* old version */
// Remove old:
theObj = document.getElementById(top.fsMod.navFrameHighlightedID[frameSetModule]);
if (theObj) {
theObj.setAttribute("class", "");
}

// Set new:
top.fsMod.navFrameHighlightedID[frameSetModule] = highLightID;
theObj = document.getElementById(highLightID);
if (theObj) {
theObj.setAttribute("className", "navFrameHL");
}

/* new with correction */
// Remove old:
theObj = document.getElementById(top.fsMod.navFrameHighlightedID[frameSetModule]);
if (theObj) {
if (bw.ie5) {
theObj.setAttribute("className", "");
} else {
theObj.setAttribute("class", "");
}
}

// Set new:
top.fsMod.navFrameHighlightedID[frameSetModule] = highLightID;
theObj = document.getElementById(highLightID);
if (theObj) {
if (bw.ie5) {
theObj.setAttribute("className", "navFrameHL");
} else {
theObj.setAttribute("class", "navFrameHL");
}
}

Tested on Mozilla 1.5.0.1 and IE6.

(issue imported from #M2874)


Files

typo3-4.0-navframehighlightIE.diff (776 Bytes) typo3-4.0-navframehighlightIE.diff Administrator Admin, 2006-04-14 15:20
Actions #1

Updated by Ernesto Baschny over 18 years ago

Sebastian: The change you introduced in:

http://cvs.sourceforge.net/viewcvs.py/typo3/TYPO3core/typo3/alt_db_navframe.php?r1=1.22.2.4&r2=1.22.2.5

doesn't work on IE, therefore there is no highlighting of the currently selected row in the page-hierarchy.

The solution from Vincend Guarard works fine. I just made a patch out of it. Could you try to get that included in HEAD with the core team?

Actions #2

Updated by Sebastian Kurfuerst over 18 years ago

hi,

I'll take care of it!
Greets, Sebastian

Actions #3

Updated by Sebastian Kurfuerst over 18 years ago

Hi Ernesto,
I am currently crammed with work, might it be possible for you to take care of that bug?

Thanks :)
Sebastian

Actions #4

Updated by Rupert Germann over 18 years ago

Fixed in CVS by Ernesto Baschny

Actions

Also available in: Atom PDF