Project

General

Profile

Actions
Copy link

Feature #17527

closed

Recursive include of external Typoscript Files

Added by Martin Ficzel over 17 years ago. Updated over 16 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Michael Stucki
Category:
Communication
Target version:
-
Start date:
2007-08-13
Due date:
% Done:

0%

Estimated time:
PHP Version:
5.0
Tags:
Complexity:
Sprint Focus:

Description

Currently it is not possible to use more than one level of external ts-files because the parser is not checking the included scripts for includes. So teh use of external ts is not possible in larger projects with a lot of ts code.

Only one line of code has to be changed in class.t3lib_tsparser,php to enable recursive inclusion. See included patch.

Regards Martin

Maybe additional code should be added to avoid circular includes.
(issue imported from #M6138)

Files

Download all files
patch_recursive_ts_include.txt (933 Bytes) patch_recursive_ts_include.txt Administrator Admin, 2007-08-13 15:46
bug_6138.diff (2.83 KB) bug_6138.diff Administrator Admin, 2007-08-13 23:37
Actions
Copy link
 #1

Updated by Michael Stucki over 17 years ago

Thanks for your patch, Martin. Attached is an enhanced version which includes loop protection and removes the uninteresting comment while browsing with the TypoScript Object Browser.
I'm going to post this for review immediately, but please try it out anyway...

- michael

Actions
Copy link
 #2

Updated by Martin Ficzel over 17 years ago

the patch with recursion protection for t3lib_tspartser works for me but the patch for the second file does'nt work (error on apply patch). i did'nt do furter testíng but looked at the code.

as far as i see it schould avoid the include comments in template analyzer but thats a feature i personally would miss.

regards Martin

Actions
Copy link
 #3

Updated by Michael Stucki about 17 years ago

Fixed in SVN. Thanks Martin!

Actions
Copy link

Also available in: Atom PDF