Project

General

Profile

Actions

Bug #18064

closed

Bogus check in handler_getFromTableList

Added by Oliver Klee almost 17 years ago. Updated over 16 years ago.

Status:
Closed
Priority:
Should have
Category:
Database API (Doctrine DBAL)
Target version:
-
Start date:
2008-01-28
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

From class.ux_t3lib_db.php in the current trunk:

function handler_getFromTableList($tableList)    {
$key = $tableList;
if (!isset($this->cache_handlerKeyFromTableList[$key]))    {
// Get tables separated:
$_tableList = $tableList;
$tableArray = $this->SQLparser->parseFromTables($_tableList);
// If success, traverse the tables:
if (is_array($tableArray) && count($tableArray)) {
foreach($tableArray as $vArray) {
// Find handler key, select "_DEFAULT" if none is specifically configured:
$handlerKey = $this->table2handlerKeys[$vArray['table']] ? $this->table2handlerKeys[$vArray['table']] : '_DEFAULT';
// In case of separate handler keys for joined tables:
if ($outputHandlerKey && $handlerKey != $outputHandlerKey) {
die('DBAL fatal error: Tables in this list "'.$tableList.'" didn\'t use the same DB handler!');
}

$outpuHandlerKey is never intialized. So the if never is triggered.

(issue imported from #M7295)


Files

7295.diff (2.42 KB) 7295.diff Administrator Admin, 2008-01-28 16:24
dbal.diff (1.28 KB) dbal.diff Administrator Admin, 2008-02-03 15:14
Actions #1

Updated by Michael Stucki almost 17 years ago

Committed in revision @3050.

Actions

Also available in: Atom PDF