Project

General

Profile

Actions

Bug #18535

closed

support html-tags in crop function of stdWrap

Added by Typoheads GmbH about 16 years ago. Updated almost 14 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2008-04-01
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.3
PHP Version:
4.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

current text crop function doesn't take html tags in account.

example:
temp.mytext = TEXT
temp.mytext.field = text
temp.mytext.crop = 150|...|1

(possible) html output:

lorem ipsum dolor <b>sit amet...

needs a logical parsingfunction which closes open html-tags
(issue imported from #M7984)


Files

bug_7984.diff (4.44 KB) bug_7984.diff Administrator Admin, 2008-04-02 22:45
bug_7984_typo3_4.1.6.diff (4.45 KB) bug_7984_typo3_4.1.6.diff Administrator Admin, 2008-04-02 23:08
bug_7984_v2_typo3_4-1-6.diff (4.62 KB) bug_7984_v2_typo3_4-1-6.diff Administrator Admin, 2008-04-03 11:57
bug_7984_v3_typo3_4-1-6.diff (4.67 KB) bug_7984_v3_typo3_4-1-6.diff Administrator Admin, 2008-04-03 16:26
bug_7984_typo3_4-2-0RC1.diff (4.83 KB) bug_7984_typo3_4-2-0RC1.diff Administrator Admin, 2008-04-10 12:20
CropTest.php (11 KB) CropTest.php Administrator Admin, 2008-04-10 12:21
bug_7984_4-3.diff (5.66 KB) bug_7984_4-3.diff Administrator Admin, 2008-08-11 18:41
bug_7984_v5_typo3_src-trunk.diff (6.6 KB) bug_7984_v5_typo3_src-trunk.diff Administrator Admin, 2009-08-27 11:31

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Feature #16836: Featurerequest: stdWrap.cropHtmlClosed2007-01-06

Actions
Actions #1

Updated by Typoheads GmbH about 16 years ago

lorem ipsum dolor <b>sit amet...
Actions #2

Updated by Jochen Rau about 16 years ago

The patch solves the decribed problem and ensures the correct char count (chars of tags ar not counted; entities are decoded).

Actions #3

Updated by Typoheads GmbH about 16 years ago

fyi: bug_7984.diff against 4.2RC1

Actions #4

Updated by Jochen Rau about 16 years ago

Added patch for TYPO3 4.1.6

Actions #5

Updated by Jochen Rau about 16 years ago

The new patch (bug_7984_v2_typo3_4-1-6.diff) takes the "link" tag into account. Thanks to Boris for testing.

Actions #6

Updated by Jochen Rau about 16 years ago

The new patch (bug_7984_v3_typo3_4-1-6.diff) solves a problem (no content was shown, if the number of chars is larger than the content length).

Actions #7

Updated by Typoheads GmbH about 16 years ago

+1 after testing in 4.1.5

Actions #8

Updated by Jochen Rau about 16 years ago

The new patch (bug_7984_typo3_4-2-0RC1.diff) closes cropped tags, respects entities and is unit-tested (CropTest.php). For plain text the patched version of crop behaves exactly as the original version.

Actions #9

Updated by Michiel Roos almost 16 years ago

Boris!

Please post this as a RFC to the core list!

Actions #10

Updated by Jochen Rau almost 16 years ago

I posted an RFC on April 4th 2008 on .

Actions #11

Updated by Michiel Roos almost 16 years ago

Well Jochen,

That's a nice discussion! Good work.

For posterity: http://lists.netfielders.de/pipermail/typo3-team-core/2008-April/015278.html

So, now we wait. Dmitry is already Monitoring, Stucki will look at it this evening, Patrick has just escaped to the US . . . .

Actions #12

Updated by Dmitry Dulepov almost 16 years ago

Re-posted the patch to the core list. Now it uses cropHTML property.

Actions #13

Updated by Michiel Roos almost 15 years ago

So here we are one year later, and we have a 'relationship'.

Nice!

:-)

Actions #14

Updated by Jochen Rau almost 15 years ago

This was mainly to bubble the thing out again. I was a little bit exhausted after the lengthy discussion on the core list. But I am currently preparing a post to sum up the discussion. I really want this feature get into 4.3.

Actions #15

Updated by Jochen Rau almost 15 years ago

Committed with rev. 5857

Actions

Also available in: Atom PDF