Project

General

Profile

Actions

Bug #19062

closed

if redirect_url / login error

Added by Alex Widschwendter almost 16 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Category:
felogin
Target version:
-
Start date:
2008-07-04
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

if a redirect_url is set (via $_GET), one is redirected to the redirect_url upon wrong authorization. i would aspect a call to the login page with an error msg.

if addtionally a error redirect pid is set (to the login form), one is redirected to the login form, but no error is shown, just the login form in its inital form (welcome) and the redirect url (upon succesful login) is lost.

(issue imported from #M8903)


Files

8903_felogin.diff (2.2 KB) 8903_felogin.diff Administrator Admin, 2008-11-02 12:57
Actions #1

Updated by Thomas Breuss over 15 years ago

I had the same problem with fe_login version 1.0.0.

The problem comes from method tx_felogin_pi1::processRedirect(). If redirect options are set to "defined by GET/POST-Vars" the return value will be empty.

So on line 97 of class tx_felogin_pi1 the member var $this->redirectUrl will be set with an empty value.

My solution to fix this was:

On line 293 of class.tx_felogin_pi.php i have replaced
$markerArray['###REDIRECT_URL###'] = $this->redirectUrl;
with
$markerArray['###REDIRECT_URL###'] = t3lib_div::_GP('redirect_url');

Actions #2

Updated by Steffen Kamper over 15 years ago

This solution is not the right one.

I attached a fix so the GP-redirecturl is passed for this cases, also after login error.

Actions #3

Updated by Steffen Kamper over 15 years ago

comitted to Trunk rev 4461

Actions #4

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF